Concrete Dependency in SigningKeyStore about identityserver HOT 10 CLOSED

Referenced pull request fixes this issue.

from identityserver.

Hi @BenWolstencroft -- The reason I added the concrete dependency was because we needed to handle the concurrency scenarios, but perhaps we already had such checks in the interface base abstraction (tho I doubt it). I'll have a look at the PR.

from identityserver.

Hi @brockallen - thanks for the response.. if that's the case then I guess I can try adding a transient service to the builder. I'll be honest I thought that the concrete dependency was accidental - the other repositories in the same folder all have the IPersitedGrantDbContext - you guys know the detail better than I do!

from identityserver.

Yea, I know the other locations use the abstraction... this was a first cut, so I can think about it some more. To be honest I don't think I ever liked the DbContext abstraction. Do you use it at all (for testing), by any chance?

from identityserver.

@brockallen - looking through our codebase, i'll be honest it looks like we've implemented all of our extension methods etc using the IPersistedGrantDbContext as the type parameter, but only because it's the 'right thing to do' given there's an interface available. I don't think we would actually miss it (in our implementation) if it were gone.

For unit testing we simply switch our EF provider over from the PostgreSql to the InMemory Implementation, rather than making any replacements of the DbContext service itself.

from identityserver.

Ok, thanks for that feedback on your usage.

from identityserver.

Thanks Ben. I did a fix and we are publishing an updated preview now.

from identityserver.

@brockallen - just to confirm, should the change be in preview.2.12 ? looking at the code in the dll it appears to still be the concrete dependency, i'm still getting the service resolution exceptions thrown.

from identityserver.

Seems there was a timing issue...preview.2.13 on the way...

from identityserver.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.

from identityserver.