Add extensibility points to the /connect/authorize/callback endpoint about identityserver HOT 8 CLOSED

Hi @CoderNumber1 -- In our next release we have opened up our response generation to be extensible to allow thing like your request:

#1342

from identityserver.

Well, we were going to wait until we got feedback. So that's a start. Have a deeper look and provide some ideas on how we would need to change it so you can extend what you need/want to.

from identityserver.

@brockallen fantastic timing! We'll be keeping a close eye on 7.0 then!

I was looking over the changes in that PR, and I have a follow-up question. Looking at the current default IEndpointResultGenerator<AuthorizeResult> implementation it would still be an internal class as of right now. Meaning we could inject our own IEndpointResultGenerator<AuthorizeResult>, but we would need to duplicate the entirety of the behavior that the current default exhibits in order to override the subset that returns the form post response.

Are there any plans to make that a public class, and possibly make some of the currently private methods protected virtual, such as GetFormPostHtml?

from identityserver.

@CoderNumber1 - any further thoughts on what you'd like to be able to extend in the result generators?

from identityserver.

My apologies, I've been buried and this fell off my radar.

In particular all I really need is to be able to extend on the current AuthorizeResultGenerator is the GetFormPostHtml(AuthorizeResponse response) method. I don't even really need to be able to override the entirety of the response, just inject additional content for the body of the page. If that method were protected virtual instead of private I could just inherit from the existing implementation and override the one method. This would save me from having to implement the entirety of IEndpointResultGenerator<AuthorizeResult> for a change to one type of response it generates.

What we're really after at the end of the day is to place our logo and a message into the body of that html so that the user sees something besides a blank page while they're waiting on the target application to load if it's slow in responding.

from identityserver.

No problem @CoderNumber1 - we appreciate your feedback!

@brockallen, let's discuss this.

from identityserver.

Yea, I guess we could add nop virtuals for things like AddHtmlHead and AddHtmlBody. Is this the kind of thing you're looking for @CoderNumber1?

from identityserver.

Yeah I think that might give us what we're looking for.

from identityserver.