ducktors / arecibo Goto Github PK

Is arecibo compatible with the latest version of Fastify? Seems like ^3.0.0 ^4.0.0 is not working. In this case, I would open a PR since I need it 😄

UPDATE: I can confirm that ^3.0.0 ^4.0.0 is not the correct format, ^3.0.0 || ^4.0.0 works fine, opening a PR.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Describe the bug
We are using fastify together with typescript in our environment. We would love to use arecibo, but we cannot use:

import * as fastify from 'fastify'
import * as arecibo from 'arecibo'

const server = fastify()
server.register(arecibo)

and

We get the following error:

[ERROR] 08:09:01 ⨯ Unable to compile TypeScript: 

src/index.ts(26,19):
error TS2345: 
Argument of type 'typeof import("/Users/XXXX/Development/appname/node_modules/arecibo/lib/index")' 
is not assignable to parameter of type 'Plugin<Server, IncomingMessage, ServerResponse, { readinessURL: string; livenessURL: string; }>'.

Type 'typeof import("/Users/XXXX/Development/appname/node_modules/arecibo/lib/index")'

provides no match for the signature 

'(instance: FastifyInstance<Server, IncomingMessage, ServerResponse>, opts: { readinessURL: string; livenessURL: string; }, callback: (err?: FastifyError) => void): void'.

When we do:

import * as fastify from 'fastify'
const arecibo = require('arecibo')

const server = fastify()
server.register(arecibo)

or

import * as fastify from 'fastify'
import * as arecibo from 'arecibo'

const server = fastify()
server.register(arecibo as any)

Everything is running fine.

For me it feels like something in the calling signature in fastify 2.0.0 changed, which breaks the plugin.

To Reproduce

1. Setup a base project using typescript like https://github.com/fastify/fastify/blob/master/docs/TypeScript.md
2. install arecibo
3. import it like described and start the server

Expected behavior

Should result in the same behaviour.