Feature Request: DuckPAN Package/Code Reloading about p5-app-duckpan HOT 8 CLOSED

I am currently working on this. I expect something later today.. maybe tomorrow if things go sideways.

from p5-app-duckpan.

Fixed! Thanks to #196

from p5-app-duckpan.

@moollaza Can we modify this at all not to reload on js or css files? (?i)(js|css)$ https://github.com/duckduckgo/p5-app-duckpan/blob/master/lib/App/DuckPAN/Restart.pm#L95

No need to reload the server for js or css changes? Unless a flush of cache is required?

from p5-app-duckpan.

@MrChrisW that sounds like a good idea, the CSS/JS gets pulled on refresh, so it might be overkill to restart the process for those.

@zachthompson any thoughts?

from p5-app-duckpan.

@moollaza @MrChrisW That would probably be fine. Most files in share don't require a reload, except for the *.txt files.

from p5-app-duckpan.

@MrChrisW care to submit a PR? or make an issue?

from p5-app-duckpan.

@moollaza @MrChrisW See if #218 does what you expect. There are more than .txt files in /share/ that might require a reload, e.g. .yml. So it just skips js, css, and handlebars files.

from p5-app-duckpan.

Fixed in #218

from p5-app-duckpan.