offset parameters not respected? about vkfft HOT 4 CLOSED

Hello,

You were correct, this was indeed a bug that occurred when buffers were provided at launch time. I have fixed it in the last version and added an option to provide offsets at launch time.

from vkfft.

Thanks for addressing this so quickly! (I should've thought to point out that I was indeed setting buffers only at launch time.)

I'm now testing all combinations of zero and nonzero offsets for transforms, and I think I've found one bug. I observed that transforms that pass input and main buffers are incorrect when the input offset is zero but the main buffer offset is nonzero. I think these two lines of the diff are the culprit; commenting them out fixed this issue. Was there a separate reason for those offsets to be changed as such?

from vkfft.

This was more of a failsafe, that backfired when inputOffset is actually zero and bufferOffset is not zero. It is not really needed, as offsets are configured in the same layout as buffers, so should always use respective values.

from vkfft.

Great, then to the extent of my testing this issue can be closed. Thank you again!

from vkfft.