Use enum for precision about vkfft HOT 2 OPEN

Hello,

This can be done, but to have backward compatibility, I would rather do something simple, like

#define VKFFT_PREC_FP32 0
#define VKFFT_PREC_FP64 1

As for the rework of inputPrecision and so on, it is better to wait until the callback functionality is formalized and added.

Best regards,
Dmitrii

from vkfft.

Hi,

so as I understand it, you suggest that the structure of the VkFFTConfiguration structure could look like:

typedef struct {
  // ...

  pfUINT doublePrecision;
  pfUINT quadDoubleDoublePrecision;
  pfUINT quadDoubleDoublePrecisionDoubleMemory;
  pfUINT halfPrecision;
  pfUINT halfPrecisionMemoryOnly;
  pfUINT doublePrecisionFloatMemory;

  VkFFTPrecision precision;
  VkFFTPrecision execPrecision;

  // ...
} VkFFTConfiguration;

where

• precision would setup the memory precision and default precision for execution and
• execPrecision if set would set up the execution precision.

The behaviour then would be:

• if none of the precision variables is set, float precision is used as today
• if any of the old precision variables (doublePrecision, halfPrecision, ...) was specified, they would have the highest preference and everything would work as today
• if precision is specified, the memory and execution precision is set to the value
• if execPrecision is specified, the execution precision set by precision is overrided to the given value

Do I get it right?

And I do not understand why it would be better to define the precision values as macros instead of an enum. What is the motivation?

Thank you.

Best regards
David

from vkfft.