dt / ghlink Goto Github PK

Hi @dt

I am debugging my extension and I can see this error message in the console.

Activating extension dt.ghlink failed: Path must be a string. Received undefined.

GitLab has very similar structure to GitHub, could you make this work for GitLab remotes as well?

Right now, the extension hasn't got any context awareness. It matches patterns regardless of where they occur and whether it makes sense.

It would be awesome if there were some settings which could restrict the links to specific contexts and languages. This file could help you if you decided to implement this feature and weren't familiar with contexts in VS Code extensions.

The settings file could look something like this:

{
  "ghLink.contexts": "*",
  
  "[javascript]": {
    "ghLinks.contexts": "comments"
  },
  
  "[ruby]": {
    "ghLinks.contexts": ["comments", "strings"]
  }
}

Idea for a feature request.

Show a panel (treeView) which lists info for the issues linked to in the current document. Or, show info on hover with a popup.

The extension generally works quite well, but sometimes I encounter false positives that could be avoided by making the matching a bit stricter, for instance:

I don't think I've ever seen a leading zero in an issue link (though GitHub seem to be fine with it actually).

Here is my .git/config:

[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
[remote "origin"]
	url = [email protected]:NetdirectFR/vitrine.git
	fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
	remote = origin
	merge = refs/heads/master

As you can see, the origin remote is properly configured and set to a valid repository (private, could this be an issue?). However simple "#issueNumber" texts are not linked:

Is it supposed to work? Is there an issue in my config?

Hey,

Since I'd imagine that this is often used in Markdown files (like README.md), I think it would be a dandy feature to be able to import the syntax to link to the GitHub repository/issue. i.e. if you write @dt/ghlink, you could set it to automatically (or manually) change it to [@dt/ghlink](https://github.com/dt/ghlink) in Markdown files.

It'd be really cool if you could also use this to link to a repository by using @username/repository.
/CC @dt

Hi there,

great extension. Github Enterprise support basically would require another hostname instead of github.com.
Would it be possible to check for github.com and if configured another hostname or a list of hostnames?