Giter Club home page Giter Club logo

bank-xp-value's People

Contributors

adamk33n3r avatar dseeler avatar hjdarnel avatar iprodigy avatar srutstein21 avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar

bank-xp-value's Issues

Missing Items

2 things here. 1. Mithril ore is not showing up as a smithing item. 2. Can you have logs show up as construction/fletching xp in the calcs? It seems weird that banked teaks and mahoganies arent con xp and banked yew and magics arent fletching as well.

[Suggestion] Add looting bag and death storages as an toggle option for UIM's "banked experience"

The suggestion is pretty much already on the title, but to further clarify I would like to see the experience of item stacks inside death storages (such as Hespori) and looting bag on my UIM, because it's the way most UIMs store their items.

In general it would also be nice to have option to see exp value of noted item stacks, regardless of where they are stored (including your inventory).

Also having option to toggle the overall "Banked XP" inside death storages would be nice too (the same way it works in regular banks currently), preferably the right click option for it should be attached to the "take all button"

Client crashes after odd interaction with Inventory Setup plugin

I've stumbled across an odd interaction between this plugin and the Inventory Setup plugin that crashes the Runelite client.

The bug occurs as follows:

  1. I log in.
  2. I go to a bank and click on either the teller or the booth with the 'Bank' option.
  3. I enter my pin by clicking on the numbers.
  4. When in the bank, I open the following setup with the 'View Setup' option (the eye icon):
    {"inventory":[{"id":9739,"name":"Combat potion(4)","quantity":1,"fuzzy":false},{"id":9739,"name":"Combat potion(4)","quantity":1,"fuzzy":false},{"id":2434,"name":"Prayer potion(4)","quantity":1,"fuzzy":false},{"id":2434,"name":"Prayer potion(4)","quantity":1,"fuzzy":false},{"id":9739,"name":"Combat potion(4)","quantity":1,"fuzzy":false},{"id":9739,"name":"Combat potion(4)","quantity":1,"fuzzy":false},{"id":2434,"name":"Prayer potion(4)","quantity":1,"fuzzy":false},{"id":2434,"name":"Prayer potion(4)","quantity":1,"fuzzy":false},{"id":995,"name":"Coins","quantity":40,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":13393,"name":"Xeric\u0027s talisman","quantity":1,"fuzzy":false},{"id":-1,"name":"","quantity":0,"fuzzy":false},{"id":-1,"name":"","quantity":0,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":11806,"name":"Saradomin godsword","quantity":1,"fuzzy":false},{"id":8013,"name":"Teleport to house","quantity":1,"fuzzy":false},{"id":24478,"name":"Open herb sack","quantity":1,"fuzzy":false},{"id":12791,"name":"Rune pouch","quantity":1,"fuzzy":false}],"equipment":[{"id":11865,"name":"Slayer helmet (i)","quantity":1,"fuzzy":false},{"id":6570,"name":"Fire cape","quantity":1,"fuzzy":false},{"id":6585,"name":"Amulet of fury","quantity":1,"fuzzy":false},{"id":4151,"name":"Abyssal whip","quantity":1,"fuzzy":false},{"id":9674,"name":"Proselyte hauberk","quantity":1,"fuzzy":false},{"id":12954,"name":"Dragon defender","quantity":1,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":9676,"name":"Proselyte cuisse","quantity":1,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":22981,"name":"Ferocious gloves","quantity":1,"fuzzy":false},{"id":11840,"name":"Dragon boots","quantity":1,"fuzzy":false},{"id":-1,"name":"null","quantity":0,"fuzzy":false},{"id":11773,"name":"Berserker ring (i)","quantity":1,"fuzzy":false},{"id":22945,"name":"Rada\u0027s blessing 3","quantity":1,"fuzzy":false}],"rune_pouch":[{"id":561,"name":"Nature","quantity":100,"fuzzy":false},{"id":554,"name":"Fire","quantity":500,"fuzzy":false},{"id":-1,"name":"","quantity":0,"fuzzy":false}],"additionalFilteredItems":{"4162":{"id":4162,"name":"Rock hammer","quantity":1,"fuzzy":false},"19634":{"id":19634,"name":"Soul bearer","quantity":1,"fuzzy":false},"9811":{"id":9811,"name":"Farming cape(t)","quantity":1,"fuzzy":false},"9813":{"id":9813,"name":"Quest point cape","quantity":1,"fuzzy":false},"13116":{"id":13116,"name":"Bonecrusher","quantity":1,"fuzzy":false}},"name":"Slayer Melee Prayer","notes":"","highlightColor":{"value":-16711869,"falpha":0.0},"highlightDifference":true,"filterBank":true,"unorderedHighlight":false,"spellBook":0}
  5. The client crashes.

This does not occur every time that I login or every time I follow these steps when going to a bank later on in my session. I'll keep trying to find a way to reproduce this bug later today to see if this is indeed the issue.

Here are my error logs from the two days that this has happened:

May 19th: hs_err_pid2792.log

May 22nd: hs_err_pid1188.log

Here are my client logs from the two days:

Here are my logs from the two days that this bug occurred.

client_2021-05-19.0.log

The crash seems to occur between these two lines:
2021-05-19 16:31:00 [Client] INFO c.f.controller.FlippingPlugin - starting slot timers on login
2021-05-19 16:32:09 [RuneLite] INFO net.runelite.client.RuneLite - RuneLite 1.7.8.1 (launcher version 1.6.0) starting up, args: none

client_2021-05-22.0.log

The crash seems to occur between these two lines:
2021-05-22 13:42:18 [Client] INFO c.f.controller.FlippingPlugin - starting slot timers on login
2021-05-22 13:43:30 [RuneLite] INFO net.runelite.client.RuneLite - RuneLite 1.7.8.1 (launcher version 1.6.0) starting up, args: none

After discussing with owner of the Inventory Setup plugin, he believes that the issues is most likely caused by some weird interaction between InventorySetups and Bank Xp Value that causes a nullptr somehow, perhaps during filtering. He suggests having some null checks here: https://github.com/dseeler/bank-xp-value/blob/master/src/main/java/com/bankxpvalue/BankXpValueItemOverlay.java#L61

My issue I opened with the Inventory Setup is here: dillydill123/inventory-setups#87

Center box Doesn't Display & HA Heatmap is shown instead

I've tried toggling a few plugins on/off but nothing seems to change this behavior. Rather than showing the banked xp available in my bank, a High Alch heatmap is shown instead. I've attached two screenshots of this behavior below. Due to the strange behavior, I assume it's conflicting with the "Bank Heatmap" plugin somehow, but like I said before, it doesn't seem to change whether I toggle the plugin on or off. Same with your Banked XP plugin. Apologies if this is user error. Thank you for your plugin!

Before clicking "Toggle Banked XP": https://i.imgur.com/2cLbEY1.png

After clicking "Toggle Banked XP": https://i.imgur.com/zCobnLS.png

Menu Drag Functionality?

Can you please let the xp viewer be draggable? I would be convenient to move elsewhere on my screen so I can look at the viewer and the bank simultaneously.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.