drzowie / image-noise-gate Goto Github PK

Hi,

I now know a few who have struggled with starting to use this package. I just wanted to make a couple of suggestions that would help with basic issues.

First, the module when downloaded is stored in the folder named 'image-noise-gate'. If using a single location for python modules (that is scanned for existing modules, e.g. by it being in your PYTHON_PATH), then this folder name cannot be imported as a module, i.e. from image-noise-gate.noisegate import noise_gate_batch does not work. This is due to the hyphens. So I would change this to underscores.

Second, those not familiar with Cython (like myself) struggle to get started. I would add a couple of lines more to the readme that discuss building the module, and maybe an example import statement. Happy to add these myself and make a pull request.

Hi,

I am just trying to give the code a whirl but I am running into problems when trying to import to python.

from image_noise_gate import noisegate
-----------------------------------------------------------
ModuleNotFoundError       Traceback (most recent call last)
<ipython-input-55-cece792c5681> in <module>
----> 1 from image_noise_gate import noisegate

~/py_routines/image_noise_gate/noisegate/__init__.py in <module>
      4
      5 # Primary tools
----> 6 from .tools import *

ModuleNotFoundError: No module named 'image_noise_gate.noisegate.tools'