drupal-ukraine / advanced_forum Goto Github PK

Hi all,

I don't know if D8 advanced forum will be a "simple" port from D7, or a complete architectural rewrite all entities based. If the last is the case, please take a look to (entity based) Harmony Forum (https://www.drupal.org/node/2233303) and consider to join forces to output the best D8 forum solution!

Thank you

According to example https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/.travis.yml#L43 we can now approach sniffers checkers from @propeoplemd/cibox project

Might be best to regenerate your keys unless this was intentional?

advanced_forum/provisioning/files/dot/ssh/id_rsa

Let's convert getInfo method to annotations.

1. Test class getInfo() method removed in favor of PHPDoc
   https://www.drupal.org/node/2301125
2. Test framework PHPUnit has been added
   https://www.drupal.org/node/2012184

Related to https://www.drupal.org/node/2118119

• Prepare environment #3
  • VM #3
  • D7 #3
  • D8 #5
  • Contribs #4
  • Initial Advanced Forum module #6
• For ability to build proper Architecture we need to investigate features list that already is in D7 version.
• After getting full list of features - we need to draw a line over features that covered by core and stable contribs for not copy their functionality, but just reuse it within @drupal-ukraine/advanced-forum project
• for the list of unique and needed features we need to create Architecture and to approach them as a project for D8

Let's create empty admin page(without form for settings).
See advanced_forum_settings_page().

Some examples:
/advanced_forum.routing.yml

advanced_forum.admin_settings:
  path: '/admin/config/content/advanced-forum'
  defaults:
    _form: '\Drupal\advanced_forum\Form\SettingsForm'
    _title: 'Advanced Forum settings'
  requirements:
    _permission: 'administer advanced forum'

/src/Form/SettingsForm.php

<?php

/**
 * @file
 * Contains \Drupal\advanced_forum\Form\SettingsForm.
 */

namespace Drupal\advanced_forum\Form;

use Drupal\Core\Form\ConfigFormBase;
use Drupal\Core\Form\FormStateInterface;

/**
 * Defines a form that configures advanced forum settings.
 */
class SettingsForm extends ConfigFormBase {

  /**
   * {@inheritdoc}
   */
  public function getFormId() {
    return 'advenced_forum_admin_settings_form';
  }

  /**
   * {@inheritdoc}
   */
  protected function getEditableConfigNames() {
    return [
      'advanced_forum.settings',
    ];
  }

  /**
   * {@inheritdoc}
   */
  public function buildForm(array $form, FormStateInterface $form_state, Request $request = NULL) {
    // @todo implement settings form.
    return parent::buildForm($form, $form_state);
  }

  /**
   * {@inheritdoc}
   */
  public function submitForm(array &$form, FormStateInterface $form_state) {
    // @todo implement submit handler.
  }
}

Related to https://www.drupal.org/node/2291273

Due to #11
We need to fix submit handler for admin page for ability to get form storing options.
Due to changes about variables->config we can start to work on migrations of changed variables for future upgrade path

• Define default values for form configs #27
• Fix all @d7 todo items within a form (small issues, can be splitted) #28
• Approach submit callback #27
• Add migration for variables->config for future D7->D8 upgrade

When #27 landed there are tasks to be done from code

1. @todo $node_types = _node_types_build()->types; https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L83 and https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L100
2. Remove/implement https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L153
3. Define forum containers https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L187 and https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L199
4. Check image module is the same https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L206
5. Port taxonomy vocabulary list https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L217
6. Port field_info_instances() https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L221
7. Convert system_get_date_types() https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L282 Simple one
8. Set default date type https://github.com/drupal-ukraine/advanced_forum/blob/8.x-1.x/d8/modules/custom/advanced_forum/src/Form/AdminSettingsForm.php#L292 - pre Novice )))

Let's start converting test to new Drupal 8.

1. Namespace and naming changes for test classes of automated tests
   https://www.drupal.org/node/1543796
2. PSR-4 compatible class loader in core
   https://www.drupal.org/node/1320394

Related to https://www.drupal.org/node/2118119

Hi, today I tried to install it in a Drupal 9.1.2 site and got a message that it's not compatible.
It looks like the whole project is abandoned. Do you plane to continue development?

Let's implement uninstall behavior for variables.

Currently when you remove module, it's impossible to install it again.

Let's migrate permissions from hook_perm into Drupal 8 format.
How to https://www.drupal.org/node/2311427

Related to https://www.drupal.org/node/2291273

Quote from #2 :

The ForumAccess module does not yet have a D8 version, although there is a ticket open for porting of it (maintainers could use support). It depends on ACL (Access Control Lists), which has an alpha1 for D8; the ACL maintainers are asking for support to finish the port.

So that is the current status of what blocks using the standard external modules. Some degree of "user access control" functionality might be helpful to build directly into this module if those are not yet stable and/or if helping bring them to a stable release might cause too much delay. Building such functionality directly into this module might not be ideal, but it would effectively circumvent the "blockers".

In Drupal 7 and before one of the common ways of storing settings was using variable_get() and variable_set(). In Drupal 8 these have been replaced with the new configuration system API/storage.

More details https://www.drupal.org/node/1667896

Related to https://www.drupal.org/node/1667896

Hello. Tell me if there will be a release for Drupal 9.4. I upgraded from Drupal 7 to Drupal 9,4. I really liked advanced_forum. Please update

Let's convert setUp method to new property.

1. New simpletest class property $modules to enable modules in tests instead of WebTestBase::setUp($modules)
   https://www.drupal.org/node/1710766
2. Simpletest automated tests now use empty 'testing' profile by default
   https://www.drupal.org/node/1911318

Related to https://www.drupal.org/node/2118119

https://www.drupal.org/pift-ci-job/132824

Hi guys,

Thanks a lot for working on this! How can we work around the lack of important contrib modules for Drupal 8 that are usually needed for forum functionality, such as Private Messages and the Quote module?

Thanks!