drlippman / imathas Goto Github PK

In Embedded assessments, inline buttons (via forminlinebutton) are mis-behaving. On first page load, all inline buttons work as intended. But on question submit, periodically the inline buttons will get renamed/renumbered.

For example, span id='inlinebtn1' will get changed to span id='inlinebtn2' on question submit, which then links the span to the wrong display div.

I'll try to look into this if I have the time, but you could probably spot the issue much quicker than me.

It looks like in macros.php, line 2236, $GLOBALS['inlinebuttoncnt'] is being used. In embedded assessments, it look like that global variable is being reset due to the async nature of the embed. Every submit, the inline buttons are getting id'ed as inlinebtn2.

Two concerns:

1. Would it be possible to allow the using of a local install of MathJax?
2. ... using MathTeX instead of MimeTeX?

Thanks.

I'm using the embedded assessment type to make interactive lessons. I'd like to convert to the new method of interlacing text with questions from the /course/addquestions.php page, but I'm running into the following issue:

• I like to write everything using HTML markup, for adding classes, not letting tinyMCE mis-guess what I want, and so that back-ticks don't render math-tags in the editor.
• In addquestions.php, if you add back-ticks to the inter-laced text via HTML, the next time you load the questions page, MathJax/ASCIImath will sweep through and convert all of the delimited math to MathML tags -- which, as you know, is extremely painful to deal with via HTML.
• Because of this, I'm doing all of my inter-laced text from the assessment settings paged, because that page isn't rendering my back-ticks.

Do you suppose there's an easy way to deal with this? addquestions.php renders math on the page, for math typesetting in the question descriptions -- so I assume it just does a full sweep of the page. I'm not sure if there's any way to exclude the interlaced text from that or not.

A second, and much less pressing, question. TinyMCE's default code editor isn't really much of an editor. There appears to be a third party CodeMirror plugin for TinyMCE. Do you think it would be worth incorporating this in? I'm not sure if there are enough users editing HTML to warrant loading the plugin each time TinyMCE is used. Thoughts?

An e of 3 is used in:

Quote: "However, much smaller values of e (such as 3) have been shown to be less secure in some settings" from: https://en.wikipedia.org/wiki/RSA_(crypto system)#Key_generation

References: http://crypto.stanford.edu/~dabo/abstracts/RSAattack-survey.html

I had issues with some algorithmically generated graphs displaying incorrectly. Near what should be an asymptote, the graph would instead have a vertical line segment. (This seems to only happen when the vertical asymptote is only one unit away from a root, and possibly only when both occur on the negative x-axis.)

To check whether it might simply be a problem with my algorithm, I wrote the following:

$test=showplot("($a(x+2))/(x+3)",-10,10,-10,10,1,1,400,400)

This is the graph that resulted:

Database Query in course/masssend.php appears to need some tweaking to properly retrieve email addresses of Tutors:

if (isset($_POST['tutorcopy'])) {
	$query = "SELECT imas_users.FirstName,imas_users.LastName,imas_users.email,imas_users.id ";
	$query .= "FROM imas_teachers,imas_users WHERE imas_tutors.courseid=:courseid AND imas_tutors.userid=imas_users.id ";
	$stm = $DBH->prepare($query);
	$stm->execute(array(':courseid'=>$cid));
	while ($row = $stm->fetch(PDO::FETCH_NUM)) {
		if ($row[2]!='' && $row[2]!='[email protected]') {
			$teacheraddys[] = Sanitize::simpleASCII("{$row[0]} {$row[1]}"). ' <'. Sanitize::emailAddress($row[2]) .'>';
		}
	}
}

The menu for the mobile site doesn't show the course reports link after the gradebook link (where I would expect it to go), but the page loads fine if you type in the url.

Hey there!
Sometimes when I click on "Try another similar question", the next question is the same as the previous one. If I remember what the value is from "Show Answer" on the previous question, then that value may be resubmitted for credit. Also, questions that require submissions to be fractions will accept a "Show Answer" decimal in fraction form. So if the answer to a question is 1/6, and "Show Answer" displays the decimal .16666666, then 166666/1000000 can be submitted and be correct. I'm not sure if that is really a bug, it is only really significant if a question appears twice in a row, but I thought I'd point it out. Thanks.

When using the showtest.php from this commit it appears that homework/quizes that are setup to use Display method: embedded users can no longer can click the submit button.

actions.php and directaccess.php have 'IMathAS Confirmation' hardcoded. Can these be changed to pick up the config variable.

newer password complexity works in chrome but not edge/safari/firefox

If you end up with an empty group list, the query throws an exception.
A patch could look something like: (or you could check $stm !== false before fetching as well...)

diff --git a/course/gradeallq.php b/course/gradeallq.php
index 04c79f5..3765217 100644
--- a/course/gradeallq.php
+++ b/course/gradeallq.php
@@ -174,10 +174,12 @@
                //DB $query = "SELECT isg.stugroupid,iu.LastName,iu.FirstName FROM imas_stugroupmembers AS isg JOIN imas_users as iu ON isg.userid=iu.id WHERE isg.stugroupid IN ($grplist) ORDER BY iu.LastName,iu.FirstName";
                //DB $result = mysql_query($query) or die("Query failed : " . mysql_error());
                //DB while ($row = mysql_fetch_row($result)) {
-               $stm = $DBH->query("SELECT isg.stugroupid,iu.LastName,iu.FirstName FROM imas_stugroupmembers AS isg JOIN imas_users as iu ON isg.userid=iu.id WHERE isg.stugroupid IN ($grplist) ORDER BY iu.LastName,iu.FirstName");
-               while ($row = $stm->fetch(PDO::FETCH_NUM)) {
-                       if (!isset($groupmembers[$row[0]])) {  $groupmembers[$row[0]] = array();}
-                       $groupmembers[$row[0]][] = $row[2].' '.$row[1];
+               if ($grplist) {
+                       $stm = $DBH->query("SELECT isg.stugroupid,iu.LastName,iu.FirstName FROM imas_stugroupmembers AS isg JOIN imas_users as iu ON isg.userid=iu.id WHERE isg.stugroupid IN ($grplist) ORDER BY iu.LastName,iu.FirstName");
+                       while ($row = $stm->fetch(PDO::FETCH_NUM)) {
+                               if (!isset($groupmembers[$row[0]])) {  $groupmembers[$row[0]] = array();}
+                               $groupmembers[$row[0]][] = $row[2].' '.$row[1];
+                       }
                }

        }

When we click reply the message comes up with the html code of the message instead of just the message

When sending emails it appears to be trying to inject persons first and last name onto the front of the email. Was working fine a month ago and just updated Wednesday. Some email seems to go through correctly when I send a message and have it send an email about that message it went to my account correctly. It might be the mass email portion.

The email subject for the forgot username with include the site name such as "SITENAME Username Request", but email from forgot password will just have "Password Reset Request" and not include the sitename in it. I use [email protected] and it would be helpful for the password request ones to have the sitename in the subject.

When testing the new collapseAll feature on my Mac, it will not work, since the ctrl key enables my right-click/contextual click. I suggest that altKey with click be used instead of ctlKey with click.

When taking an assessment (projects) students can save the answer to the questions and come back and finish at a later time. This works correct however once the student submits and attempts to retake it, it no longer saves correctly.

Line breaks seem not to be working. It is displaying the "< br/>" but not actually putting a new line in.

For new users (actions.php?action=newuser&confirmed=true) , the hideonpostswidget field is not set, but it's expected to be not null. (Query failed : Field 'hideonpostswidget' doesn't have a default value)

For adding a course, the outcomes and ancestor fields are not set, but they are expected to be not null. I can modify the database to make them null, or I could add a field in the insert call in the php, but I am not sure if there is a specific value that is expected for these.

Any insight would be appreciated.

Thanks,

When attaching/uploading a file in a course the link displays correctly in the box but the url is missing the / and has %2F instead and the url does not work. If I go back to the course page the url is correct.

Using latest changes as of 2 hours ago.

This isn't an issue, just a thought. (Redirect me if there's a better place for this.)

I've been thinking it'd be nice if there was a "Quick Save" option in the question authoring environment that essentially does the same thing as "Save and Test Question," but via AJAX so a page reload isn't required (on the authoring page). Maybe add a keybinding to call the method?

Have you thought about this at all? Is there any good reasons not to implement something like this? If not, I think I might take a stab at trying to implement something along these lines. I think this type of "hot-push" workflow could be really useful when authoring questions.

Issue with numberlines with later imathas code worked fine from about a month ago. It fixes if changing $grid = "0,20,0,0,5,5,500,100"

Question code is:
$grid = "0,20,-1,1,5,5,500,100"
$answerformat = "numberline,dot"

$a = rand(1,4)
$b = rand(16,19)

$answers = array("$a,0","$b,0")

File references the older editor/plugins. Causes apache log errors.

After doing a code update, file uploads seem to have a bug. I upload a file/images say images.jpeg the link in imathas will say the correct path filestore/ufiles/22088/images.jpeg but the file that got uploaded will be ufiles22088images.jpeg instead of images.jpeg.

This is something I noticed using wamap.org. Hope this is an appropriate place to report this.

A few examples:

https://www.wamap.org/course/gradebook.php?cid=9956
https://www.wamap.org/course/gradebook.php?cid=9957
https://www.wamap.org/course/gradebook.php?cid=9958

Looks like it's a teacher-centric view, although I don't think I can actually modify or see anything sensitive. I see the various names of course sections, and the course name, etc.

File uploads get stuck at Inserting (with commit 7a8840c)... but if you close the screen and go back to show previously uploaded files it will be there. Last commit we used (6d0665d) was working fine and tested okay.

When you have a chance can we get mathjax updated to 2.6.1 with some bug fixes for 2.6.
https://github.com/mathjax/MathJax/issues?utf8=%E2%9C%93&q=milestone%3A%22MathJax+v2.6.1%22

Is it possible to add a confirm email box when registering for accounts. We have it set so that a verification email goes out and some students are typing the email wrong.

Hi, I needed to install php 5.4 to get IMathAS to run, since php 7 does not have php-mysql but only php-mysqli or php-mysqlnd. Not sure if MySQL/MariaDB running with utf8mb4 would work. I created the database with default latin1 characterset and it worked. Since php 7 does offer improved speed, something to consider for further releases.

When creating a question, IMathAS fails due to reference to a non-existent "replaceby" column in the imas_questionset table.

Error on course/moddataset.php and /course/testquestion.php similar to:
Query failed :INSERT INTO imas_questionset(…; Unknown column 'replaceby' in 'field list'

dbsetup.php does not have a replaceby column in the section where the imas_questionset table is created.

Used to be able to select the dropdown box under the listing of the users on the admin page and it used to have A-Z letters to be able to see all the accounts that begin with those letters which would show students. Now that seems to not be showing up anymore. Is this intentional or a bug?

When you get a chance can this be updated. Fixes quite a bit of table bugs and some firefox bugs. https://www.tinymce.com/docs/changelog/

I have an optional assessment that I count as an exam score. When I was using BlackBoard Learning I was able to set columns up to display running totals. If a student did not take the assessment, it did not add the total for the assessment to the overall gradepoint total. I have not been able to figure out a way to do this in IMathAS. Do you know if it's possible?

I did play around with the Extra Credit feature, but have not been able to figure out it's purpose - It adds the points to all student records, not individual ones. I have been unable to find a tutorial that explains the extra credit feature. I have watched all of the tutorials that I have found related to IMathAS.

Thank you ;-)

Could someone be kind enough to walk me through a step by step on where to download the whole repository in an apache server on a linux box?

I created a virtual domain and downloaded the file in the corresponding virtual directory, I was able to type localhost/install.php (after creating a database and a user with full privileges to the database) and it created the config.php file as well as created the tables on the database.
My next step was to do localhost/init.php but it never starts it stays forever trying to load infopages.css which I find very strange, that is why I am desperately requesting your help

Hello,

In the past you had earlier versions IMath, but I can't seem to find them now, or maybe I am not seeing them. Any help would be greatly appreciated.

Thank you!

I installed imathas on a turnkey Linux LAMP appliance just fine. When I try to login, it recognizes my login and password, but remains on the login page. Any idea what may be causing this. I looked through the php code, but I can't see anything. A session entry is created in the session directory.

The following code has an extra string and end-anchor token:

echo "Error. Please <a href=\"$imasroot/index.php\">Home</a>try again</a>";

Any chance of going to mathjax 2.7. https://www.mathjax.org/mathjax-v2-7-now-available/
Over 60 bugs fixed.

I can not login after setup of IMathAS. I get error:
"Unable to establish a session. Check that your browser is set to allow session cookies". The browsers are all set to accept cookies and work with MyOpenMath.
IMathas cloned 11. feb and installed on latest Ubuntu 14.04 with latest Apache2 and MariaDB 10.1 (in Docker containers). I have tried to set up a different session storage than the default, but no change.

I'm looking to use S3 for file storage for IMathAS, but I'm having a rough time getting it to work. Does anyone have suggestions for how to configure an S3 bucket (and policy/permissions) to get things working?

Here's what I've tried.

1. Allowing public permissions to read/write, just to make sure things were working on IMathAS's end. That was fine.
2. In config.php, provided the root-user access key, secret key, and bucket name. No luck here using the root-user credentials. I keep getting a putObject() [access denied] error.
3. I tried creating a user through the IAM system and changing its policy so that it had admin access to the S3 bucket. (I tried using an IAM policy, and a Bucket policy.) Provided those credentials to config.php but still no luck. Still got the putObject() [access denied] error.

I'm guessing I'm doing something wrong on the AWS S3 side of things, but I'm really stumped by the fact that the root user credentials (that has full access to the bucket) won't allow me to upload through IMathAS. Perhaps someone here will share with me how they went about setting up their AWS bucket.

I am trying to determine what is causing the allowfullscreen code to be filtered when adding an embedded youtube video. The editor accepts the edit, but when the code is submitted the allowfullscreen code is removed from the html. It appears that it would be happening when the code is submitted, in which case htmLawed is most likely the cause from line 105:

    $htmlawedconfig = array('elements'=>'*-script');
$_POST['text'] = addslashes(htmLawed(stripslashes($_POST['text']),$htmlawedconfig));

However the filter shouldn't change the allowfullscreen code. So, there must be something happening before that, but I can't find the code. Any pointers about where to look would be great.

Is the /admin/approvepending.php missing from the repository? I received an email request from a teacher using the link to newinstructor.php on the main index index page. After trying to view the request on the admin Home > Admin > Utilities page, Approve Pending Instructor Accounts gives a 404 error. I couldn't find the file anywhere and was just wondering if it was left out for some reason?

"<a hre=" occurs instead of "<a href=" in several files:

course/course.php:
100: $body = _("Course does not exist. <a hre=\"../index.php\">Return to main
i18n/de.po:
656: msgid "Course does not exist. <a hre=\"../index.php\">Return to main page</a>" 658: "Kurs existiert nicht. <a hre=\"../index.php\">Zurück zur Hauptseite</a>"
i18n/messages.po:
520: msgid "Course does not exist. <a hre=\"../index.php\">Return to main page</a>"

I get the following displayed when sending emails for Password resets. All the other emails that get sent have it appear correctly (Username lookups, messages). My config is set to $sendfrom = "MathAS <[email protected]>"
(Password resets)

(Message replys/sends, username requests)

We have been using IMathAS as an LTI for Canvas to run some UCSC physics courses since September 2016. We successfully ran a course of 250 students without problems in Spring 2017. We're running it again now and have been getting many issues that we're not sure are related to Canvas, or IMathAS, or their interaction. Normally on clicking on some lecture questions, an iframe in canvas appears with a continue button from IMathAS. But sometimes this frame doesn't appear making in impossible for the student to access the question. By using another browser, students are able to resolve this problem. Here is a screenshot on my browser of how it normally looks (extra edit buttons are there because I'm a teacher), and another one from a student where the continue button is missing. Any ideas as to what might be going wrong?

Any information would be appreciated.

Thanks!

Josh Deutsch

Using latest Firefox for Mac OS, long names (e.g.: firstname: Priscilla, lastname: Caballero Gonzalez) wrap poorly. See attached screenshot.

Version 4.6.7 September 18, 2017
FIXED bug where paste wasn't working in IOS.

Can we get imathas to use this version. Some fix for safari and accessibility improvements.
https://www.mathjax.org/mathjax-v2-7-2-now-available/

Not an issue but a request. Can mathas get mathjax updated to 2.6?