drkjc / colmaracademy Goto Github PK

Looks like the same issue as the 2nd section, this would be fine if they both had the same class. Since they are identical there is no reason to make classes one and two.

Meets Expectation w/ Caveat.

So on a technical since this needs a bit more work to pass, but the issues were minor things I think you understand the concepts of so I gave it a pass. Take a look at the issues I left and tackle those issues. The main problem is DRY code, or Don't Repeat Yourself. When you have sections of code that are the same, you should make one class and reuse that class when applicable. Overall the project looked pretty close to spec and had a great use of flex which is one of the hardest concepts in the course. Very well done and keep up the good work!

2 Things here, one, you should probably avoid using the words class and classes when naming a class. It can be confusing :)

Second, this is flex properly you did a good job, you just need to adjust the margin so it doesn't get all weird when full screened. Or you can alternatively set the classes to a width of 30% so after 3 the remaining automatically get pushed to the next line.

Looks like the 3rd image has a margin on it, not sure why. These 3 should have the same CSS.