drkchiloll / csco-spark Goto Github PK

https://hubot.github.com/docs/scripting/

Do you have an example on using hubot (i.e. robot.respond) to create a room?

npm version 2.0.4 (Line 235)
When downloading ZIP files the Buffer toString needs to be converted to BASE64

createRoomWithMembers.js

I am able to create new room using "createRoomWithMembers.js". However, I get the following error message in the terminal/console.

Unhandled rejection (<{"message":"xxxx...>, no stack trace)

where xxxx is the message id.

When making a call to an API, I noticed my catch is not being hit when I intentionally passed invalid information.

After looking at the code, I noticed the following:

  return new Promise(function(resolve, reject) {
    request(options, function(err, res, body) {
      if(err) resolve(err);

The last line show, should it not be if (err) reject(err); ? Otherwise how would someone using this library know that something failed without parsing/inspecting the returned message.

FYI:
Not sure if you have taken a look at it or not, but the same group that provide request also provide https://www.npmjs.com/package/request-promise to make working with Promises even easier.