Giter Club home page Giter Club logo

Comments (3)

samsonasik avatar samsonasik commented on June 18, 2024

@bradsi I don't follow latest laravel feature, could you provide the failing fixture test to show diff before and after for expected input/output for it with the rule related to it? It should be on

https://github.com/rectorphp/rector-laravel/tree/main/tests/Rector/StaticCall/RouteActionCallableRector/Fixture

Thank you.

from rector-laravel.

bradsi avatar bradsi commented on June 18, 2024

@samsonasik Thanks for replying so quick!

I'm not too clued up on Rector or fixtures, sorry. Happy to contribute where I can though, might just need a bit of guidance.

Here is an example of a named route in the old Laravel syntax:

Route::get('/test', ['as' => 'test-route', 'uses' => 'TestController@action']);

New syntax named route looks like this:

Route::get('/test', [TestController::class, 'action'])->name('test-route');

Currently, when running the RouteActionCallableRector rule, the named routes are skipped.

I hope that helps, happy to provide any more info if needed.

from rector-laravel.

samsonasik avatar samsonasik commented on June 18, 2024

Could you create failing fixture PR test for it? You can copy one of fixture and modify to show before after at

https://github.com/rectorphp/rector-laravel/tree/main/tests/Rector/StaticCall/RouteActionCallableRector/Fixture

from rector-laravel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.