Giter Club home page Giter Club logo

Comments (6)

driftingly avatar driftingly commented on June 18, 2024 1

And it looks like we are green again 🙌

from rector-laravel.

gisostallenberg avatar gisostallenberg commented on June 18, 2024

composer.json should contain the required rector version.

I run driftingly/rector-laravel v0.21.0 which works fine on rector 0.17.2 but not on 0.17.3, because in that version BetterNodeFinder::findParentType was removed, see https://github.com/rectorphp/rector/releases/tag/0.17.3

According to SemVer rector can do breaking changes, but I think it should have a new minor version (0.18.0).

from rector-laravel.

driftingly avatar driftingly commented on June 18, 2024

@gisostallenberg This package used to be part of Rector but was pulled out to allow them to stay focused. I think they are working on a 1.0 release soon so we should be able to stabilize this package soon.

from rector-laravel.

driftingly avatar driftingly commented on June 18, 2024

@gisostallenberg @freshleafmedia Just released the updates by @GeniJaho, which should resolve this issue. Let me know.

from rector-laravel.

gisostallenberg avatar gisostallenberg commented on June 18, 2024

@driftingly you mean the changes in #117?

from rector-laravel.

driftingly avatar driftingly commented on June 18, 2024

Yeah. I tried on a fresh install and latest Rector and it ran. Noticed there are some failing test though with everything merged in.

from rector-laravel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.