port sigrok changes back to upstream about dsview HOT 23 OPEN

For the record: DreamSourceLab hasn't contributed back to sigrok to this day, not even letting us know when there are bugs in protocol decoders that they took from sigrok, while still making decent money off of our work. Saying that we're not happy would be quite the understatement.

from dsview.

Hi, for all of you that still have interest in libsigrok suport for dslogic, it is almost there!
The folks at libsigrok implemented basic support, to which I added more functionality. Check my repo for the last version:

[email protected]:asanza/libsigrok.git

The last working version is in branch devel.

What is working:

• Simple trigger on any channel
• Pre-Trigger settings
• External Clock/Clock edge
• Voltage Threshold.
• Continuous (Stream) sampling.

Some of these changes are already on the development branch of libsigrok.

In order to use it you also need the binary firmware and the fpga image that comes with your dslogic.

Go to folder DSView/res and copy following files:

• DSLogic.fw
• DSLogic33.bin
• DSLogic50.bin

to the folder where sigrok-firmware is located (mine is in /usr/local/share/sigrok-firmware). After that rename them as follows:

• DSLogic.fw -> dreamsourcelab-dslogic-fx2.fw
• DSLogic33.bin -> dreamsourcelab-dslogic-fpga-3v3.fw
• DSLogic50.bin -> dreamsourcelab-dslogic-fpga-5v.fw

Enjoy!

from dsview.

Yeap! We will contact the sigrok guys for this.

from dsview.

Support for DSLogic and DSLogic Pro is now working in sigrok (only logic analyzer)

https://sigrok.org/wiki/DreamSourceLab_DSLogic
https://sigrok.org/wiki/DreamSourceLab_DSLogic_Pro

from dsview.

I aggree, contributing to upstream is very important

from dsview.

As an update to this thread, a month or two ago I started trying to change libsigrok's handling of DSLogic devices so it could match newer firmware (as well as support for the U3Pro16 analyzer for example). I only got it where it connects to sigrok, but I still gotta work on getting sigrok to read the data from the analyzer (will eventually hop back on this project)

from dsview.

Agree that avoiding source code duplication for sigrok would make DS devs life easier. It will be easier to use features and fixes from upstream sigrok.

+1 for becoming official sigrok device.

from dsview.

As for now, support in sigrok is almost complete, but it needs testing. You can checkout the last development branch. http://sigrok.org/wiki/Libsigrok

from dsview.

@benner While not done by me, somebody else did a almost full port into Sigrok and there's a PR waiting to be merged: sigrokproject/libsigrok#170

from dsview.

Indeed, this is very important.

Though, I'd guess that you'll need to try to make your changes more incremental, i.e. not one big push with lots of changes. As that will make it really hard to integrate anything back to upstream.
That's especially true when that large commit also remove lots of stuff that upstream definitely needs to keep.

I'll see if/when I can get some time to look into upstreaming DSLogic support myself, unless we can get something going earlier.

from dsview.

So what happened based on this post from you guys? It's been two years and no updates on this issue or this one. This post seems to summarize the feelings well.

from dsview.

Sounds great. Thank you!
I don't have time to check it :(

from dsview.

Any news on this?

from dsview.

Awesome! I'm about to buy a DSLogic (It's on sale with accessories for $70 on hackaday, as well as having a high max sample rate, make me want it. My max is $100 for an LA, budget being $70.) I'll use Sigrok and report any bugs I see. Hell, maybe I'll check in some code. I don't know what Sigrok is written in, so I'll do some research when I get the DSLogic.

from dsview.

Which makes me want it*

from dsview.

any progress?

from dsview.

Not that I know of. I got the DSLogic and I have been using DSView.

from dsview.

i just went through the release notes for 0.4.0 and no mention

i might get to it

how is DSView? you can email me direct

[email protected]

from dsview.

Any update on this?

from dsview.

Unfortunately I've taken upon other projects, and didn't have time to circle back to this. Might do so this weekend.

Last time I worked on this if I remember correctly, I was able to get sigrok to initiate a trigger to the DSLogic, now I got to port over reading the data properly.

from dsview.

Could you push your work to some branch and maybe other will help with testing etc?

from dsview.

I already do, it's in my libsigrok fork's DSLogicU3Pro16 branch: https://github.com/Electro707/libsigrok/tree/DSLogicU3Pro16

Full warning thought, it will connect but will not start a capture. That I still need to port, which is more difficult than I anticipated.

from dsview.

any update on this?

from dsview.