dream11 / vertx-aerospike-client Goto Github PK

Summary

https://github.com/dream11/vertx-aerospike-client/blob/master/src/test/java/io/d11/aerospike/AerospikeAddTest.java#L6
io.d11.reactivex.aerospike.client.AerospikeClient is not resolved in tests. It also doesn't appear to be a part of the project.

Summary

Instead of creating a new eventLoopGroup exclusively for the client, should we be using vert'x own eventLoopGroup instead? I'm guessing it should improve performance as per
https://docs.aerospike.com/docs/client/java/usage/async/eventloop.html#create-netty-event-loops and due to the fact that we'll be creating fewer threads.

private EventLoopGroup getEventLoopGroup(int size) { return OS.contains("linux") || OS.contains("unix") ? new EpollEventLoopGroup(size) : new NioEventLoopGroup(size); }

to

private EventLoopGroup getEventLoopGroup(Vertx vertx) { return vertx.nettyEventLoopGroup() }

The listner will no longer have to use vertx.runOnContext() since the onRecord part will already be running on vertx eventloop

• implement all operation listeners
• proper handling of policy util
• config handling with objects and use default configs provided by aerospike
• give the option to create shared and nonshared client
• create a separate interface for the client and functions
• description of every public method
• Proper exception handling, don't suppress the parent exception

• github actions to auto release
• maven publish on master merge
• version up commit on master merge

• junit tests
• integration test with docker for aerospike

Summary

On trying to create a new shared instance of AerospikeClient after closing, new instance won't be created and the old client instance will be returned. close() should also remove instance from shared data

Steps To Reproduce

Additional Details & Logs