drake25122000 / pe Goto Github PK

Issue description
User can add room booking at the past

Steps to reproduce:

1. addBooking pid/5 rid/2105 sd/2020-11-01 ed/2020-11-02

Expected result:
You cannot add booking that happened in the past or invalid booking date

Actual result:
Successfully added booking: Id: 7 Room Id: 2105 Person Id: 3 Start Date: 2020-11-01 End Date: 2020-11-02 Archived: false

Additional details / screenshot

Issue description
The person list can have more than 1 contact with the same name, phone number, email and address.

Steps to reproduce:

1. editPerson pid/2 n/Charlotte Oliveiro
2. editPerson pid/2 p/93210283
3. editPerson pid/2 e/[email protected]
4. editPerson pid/2 a/ Blk 11 Ang Mo Kio Street 74, #11-04
   Expected result:
   Duplicate contact detected

Actual result:
Edited Person: Id: 2 Name: Charlotte Oliveiro Phone: 93210283 Email: [email protected] Address: Blk 11 Ang Mo Kio Street 74, #11-04 Tags: [VIP]

Additional details / screenshot

Issue description
A booking can order wifi room service more than 1 time

Steps to reproduce:

1. orderRoomService bid/1 rst/WIFI
2. orderRoomService bid/1 rst/WIFI

3. orderRoomService bid/1 rst/WIFI
   

Expected result:
Wifi service already available in the room

Actual result:
Ordered room service:
[BookingID: 1; Service type: Wifi service; Price: $15]

Additional details / screenshot
Maybe the person must renew wifi service daily, but it is illogical for customers can order more than 1 wifi service if they only stay for 1 night

Issue description
For a contact that has a long name, the user won't be able to see the full name

Steps to reproduce:

1. addPerson n/John Doe Alex Yeoh Uvuvwevwevwe Lalalalala Haaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa p/22224444 e/[email protected]
   a/123, Clementi Rd, 1234665 t/vip t/vegetarian

Expected result:
'John Doe Alex Yeoh Uvuvwevwevwe Lalalalala Haaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'

Actual result:
'John Doe Alex Yeoh Uvuvwevwevwe Lalalalala Haaaaaaaaaaaaaaaaaaaaaaaaa...'

Additional details / screenshot

Issue description
User can add 2 persons with the exact same credentials

Steps to reproduce:

1. addPerson n/James Ho p/22224444 e/[email protected]
   a/123, Clementi Rd, 1234665 t/vip t/vegetarian
2. addPerson n/James Ho p/22224444 e/[email protected]
   a/123, Clementi Rd, 1234665 t/vip t/vegetarian

Expected result:
Duplicate person detected

Actual result:
New person added: Id: 10 Name: James Ho Phone: 22224444 Email: [email protected] Address: 123, Clementi Rd, 1234665 Tags: [vegetarian][vip]

Additional details / screenshot

No details provided.

No details provided.

Steps to reproduce:
A

1. listPerson aaaaaa
2. A

Expected result:
One word command don't have parameter
Actual result:
Listed all personsS

Additional details / screenshot

Issue description
Delete command is not too user friendly.

Steps to reproduce:
A

1. deletePerson pid/1

Additional details / screenshot
If contacts can only be deleted by their pid, might as well just set the command to be 'deletePerson PERSON_ID' instead of 'deletePerson pid/PERSON_ID' this will make it even easier to be used by fast typist.