draber / whats-the-type Goto Github PK

Hi, I'm coming from mdn/content#15772 which I'm working on a fix. I have adopted a mostly different implementation from yours, and I'd like to report a few bugs/enhancements w.r.t. your impl's behavior.

console.log(getType(class 你好 {})) // Function

The regex for JS identifiers is /[$_\p{ID_Start}][$\u200c\u200d\p{ID_Continue}]*/u. Using that would make it return 你好 correctly.

console.log(getType(1)) // Number
console.log(getType(new Number(1))) // Number

More like a feature request, but I strongly suggest you make them different. See mdn/content#15772 (comment) also.

console.log(getType(new class {}) // ""

This is arguably less useful than "object".

Also BTW, the MathMLElement issue seems to be fixed in Chrome now.