Comments (8)
the flags are 97 and 145 for the example bam, where does the discordant from BWA come in?
from methyldackel.
Exactly, those are flags for discordant alignments. 99 and 147 would be concordant (that's what bison produces, though one needs to convert the fastq files to be all uppercase for it to work (I'll add that to my list of things to fix for the next release)).
from methyldackel.
ah right.
I made up that data. does bison produce the same alignments with proper pair for cg100 and cg_R{1,2}.fq?
from methyldackel.
I think skipping unpaired should be the default. or we could just accept rf, ff like samtools
from methyldackel.
Yeah, bison produces the correct flags (well, once you make the reads upper case, otherwise it produces complete gibberish).
We can certainly default to skipping singletons (and discordant for that matter). The more I think about it, the more I think the discordant issue in the test dataset is really a bwa bug, since those aren't reasonably discordant alignments. I'll try to send a message to the bwa-help email list and see what Heng has to say (especially since this could be an issue for bwa mem/mpileup-based variant calling).
Let me know your opinion on defaulting to keeping or skipping discordants and I'll set the defaults accordingly.
from methyldackel.
Yes, I think requiring properly paired should be default
from methyldackel.
Those are now the defaults.
from methyldackel.
The most recent merges should take care of this issue. The only time pairs won't be tested for overlap now is if they're on incompatible strands (e.g., OT and OB).
from methyldackel.
Related Issues (20)
- Stand output HOT 1
- Understanding --minConversionEfficiency argument HOT 1
- Genome browsing from MethylDackel bedGraphCpG file
- per-fragment methylation HOT 2
- mbias result is different between bismark and bwameth output HOT 1
- CURL_OPENSSL conflict with samtools HOT 3
- Installation failure: "bigWig.h: No such file or directory" HOT 1
- Clarification on definition of "unmethylated C" HOT 1
- Coverage of C sites HOT 1
- mbias HOT 1
- Does indel effect the methylation calling or C context determination HOT 1
- Positions in cytosine_report did not match the regions in providing bed file
- about M-bias HOT 1
- Could not repeat a CpG extraction with the same reference file and its index
- Mixed up reads within bam file
- How to index genome file for MethylDackel? HOT 1
- Confused regarding CTOT, CTOB. Are there suggested values? HOT 3
- Issue running MethylDackel extract in parallel mode using minConversionEfficiency
- Question about minimum coverage
- Different CpG calls when using different regions of inclusion for Methyldackel extract
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from methyldackel.