Giter Club home page Giter Club logo

Comments (8)

brentp avatar brentp commented on July 22, 2024

the flags are 97 and 145 for the example bam, where does the discordant from BWA come in?

from methyldackel.

dpryan79 avatar dpryan79 commented on July 22, 2024

Exactly, those are flags for discordant alignments. 99 and 147 would be concordant (that's what bison produces, though one needs to convert the fastq files to be all uppercase for it to work (I'll add that to my list of things to fix for the next release)).

from methyldackel.

brentp avatar brentp commented on July 22, 2024

ah right.
I made up that data. does bison produce the same alignments with proper pair for cg100 and cg_R{1,2}.fq?

from methyldackel.

brentp avatar brentp commented on July 22, 2024

I think skipping unpaired should be the default. or we could just accept rf, ff like samtools

from methyldackel.

dpryan79 avatar dpryan79 commented on July 22, 2024

Yeah, bison produces the correct flags (well, once you make the reads upper case, otherwise it produces complete gibberish).

We can certainly default to skipping singletons (and discordant for that matter). The more I think about it, the more I think the discordant issue in the test dataset is really a bwa bug, since those aren't reasonably discordant alignments. I'll try to send a message to the bwa-help email list and see what Heng has to say (especially since this could be an issue for bwa mem/mpileup-based variant calling).

Let me know your opinion on defaulting to keeping or skipping discordants and I'll set the defaults accordingly.

from methyldackel.

brentp avatar brentp commented on July 22, 2024

Yes, I think requiring properly paired should be default

from methyldackel.

dpryan79 avatar dpryan79 commented on July 22, 2024

Those are now the defaults.

from methyldackel.

dpryan79 avatar dpryan79 commented on July 22, 2024

The most recent merges should take care of this issue. The only time pairs won't be tested for overlap now is if they're on incompatible strands (e.g., OT and OB).

from methyldackel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.