download / redux-apis Goto Github PK

The only occurrence of using apiLink is in the course that a custom link-er wasn't provided to link. Therefore, we should avoid using the this reference as it convolutes the meaning, and evidently is only used on the child object.

I'll submit a pull request after verifying all tests still work.

Version 3.4.0 of mocha just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As mocha is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Happens with nested API's in @@redux/INIT phase

Version 6.4.1 of babel-loader just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-loader is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

We should be able to get the handler currently attached to an action, so we can use it from our extending class.

E.g. we want to be able to do this:

class Base extends Api {
  constructor(state) {
    super(state);
    this.setHandler('SOME_ACTION', (state, action) => ({ ...state, someProp:action.payload }));
  }
}

class Derived extends Base {
  constructor(state) {
    super(state);
    const oldHandler = this.getHandler('SOME_ACTION');
    this.setHandler('SOME_ACTION', (state, action) => {
      const newState = oldHandler(state, action);
      return { ...newState, extraProp:'extra thingie' }});
  }
}

In the .getState() function, there's a call to this.__link(this.__parent.getState()) - likewise, in link()'s default definition, if child isn't defined (like in the call earlier), yet the parent object will be an object and the this parameter is still bound to the child, which does have the .__parent parameter, which then takes this code path.

Because we're only supplying the parent's .__state property to the child's .__link(), it would expect it's name to exist in the state of the parent.

How should this work / how should I be doing this?

Using the actual nested Api objects in the object returned by connector means their identity never changes, which does not work well with React's default implementation of performing a strict equals check on the props passed to a component. We need that identity to change with state changes/

Happens on older versions of Node JS / Older browsers if we don't use a polyfill. Add a polyfill for when running tests on Travis CI as build is currently failing due to this.