dotson / dj-pedro Goto Github PK

Research ways to smooth out playback start-up of of DJ Pedro's playlist for all use cases:

• iTunes is not playing, DJ Pedro begins from a stopped player state.
• iTunes is currently playing a song different from the seedTrack, not in DJ Pedro's playlist.
• iTunes is currently playing a song different from the seedTrack, in DJ Pedro's playlist.
• iTunes is currently playing the seedTrack, not in DJ Pedro's playlist.
• iTunes is currently playing the seedTrack, in DJ Pedro's playlist.

Notes:
Because of the way iTunes 11 handles playlists, there's currently a pause/un-pause coded into DJ Pedro at the start of playback. If Apple ever provides a better way to deal with Up Next, besides GUI scripting, this will be updated.

Possible results on initial search:

1. Last.fm returns no similar artists from search.
   • Fill playlist with tracks by seedArtist, either to max of available tracks by seedArtist or to playlistSize
   • Alfred pop-up ("Sorry, Last.fm doesn't seem to know this artist. Double check your spelling is correct in iTunes, or maybe you listen to really obscure music!") with link to check spelling using Last.fm page.
2. iTunes library does not have any artists from simList.
   • Fill playlist with tracks by seedArtist, either to max of available tracks by seedArtist or to playlistSize
   • Alfred pop-up ("You don't have anything similar to {query}, but you might like these artists:") showing links to first 5 simArtists, with clickable links to Last.fm
3. iTunes library has only a couple simArtists, not enough to fill playlist with current settings.
   • Override default settings and fill playlist with whatever we can fro seedArtist and found simArtists.
   • Alfred pop-up ("You don't have many artists similar to {query}, but you might like these artist:") showing links to first 5 simArtists, with clickable links to Last.fm.
4. Everything works fine, playlist fills with default settings.
   • Still show Alfred pop-up with similar artists?

Investigate how Alfred 2 uses Up Next and try to implement this method.
Possibly reach out to Workflow Help forum.

The NotFoundList script seems to fail silently when using the qWorkflow notification to OSX Notification Center.

Need to confirm the cause of this error and correct in the code.
Possibly reach out to qWorkflow author?

If DJ Pedro matches more than zero artists from "simList" within the user Library, but not enough to eventually fill a playlist, the workflow times out, throws an error, and does not complete.
Add additional recursion to begin adding more than one track per artist from "addedList" so that the workflow can complete without error.

(Consider adding notification that this has occurred so user knows to buy more music.)

Check internal code to verify this.

Add method for removing artists from "simList" as they are randomly chosen and added to the "addedList" or "notFoundList"

on remove_item(itemNumber, oldList)
set newList to {}
repeat with i from 1 to (itemNumber - 1)
set the end of newList to item i of oldList
end repeat
repeat with i from (itemNumber + 1) to (count of oldList)
set the end of newList to item i of oldList
end repeat
set oldList to newList
return oldList
end remove_item

      repeat while (count of simList) is greater then 0
          set newItem to random number from 1 to (count of simList)
          set newArtist to item newItem of simList
          set newArtist to my replace_chars(newArtist as string, "&", "+")
          set simList to my remove_item(newItem, simList)

          tell application "iTunes"
          etc etc

Hi,

I don't know if you officially support Alfred 3 at this stage. I'm hoping you do. I've got a brand new clean install of Alfred running with only one workflow: DJ-Pedro (of course).

For some reason after setting preferences (the first thing I did), I can't seem to properly start up the workflow with the dj keyword. It appears as if DJ-Pedro is fighting for supremacy with the default google search as I type. On occasion, mostly when I get between 1 and 3 characters into the artist name, I can manage to launch it but then it miserably fails.

Below is a log of the shortest failure path which didn't end in a google search:

[2016-06-13 20:19:05][ERROR: input.scriptfilter] Code 1: 2857:2910: execution error: iTunes got an error: File Macintosh HD:Users:lesparents:Music:iTunes:Alfred Album Artwork:Grateful Dead_American Beauty.jpg wasn’t found. (-43) [2016-06-13 20:19:09][input.scriptfilter] <?xml version="1.0"?> <items> <item arg=""> <title>DJ Pedro</title> <subtitle>Search for an artist to start the mix!</subtitle> <icon>icon.png</icon> </item> </items> [2016-06-13 20:19:10][input.scriptfilter] Processing output of 'action.script' with arg '' [2016-06-13 20:19:11][action.script] Processing output of 'output.notification' with arg 'Step 2 Error: Can’t get item 1 of {}. '

If it makes a difference, I'm running iTunes 12.4 on El Capitan.

I'm happy to provide any further assistance or support you may need.

Rgds,
A

Need to create a test workflow that simply caches artwork in order to speed up testing process.

Change keyword to djprefs - COMPLETED
Fix the descriptor text
Add un-actionable Title Row to explain that this is where you adjust settings.