The trace messages when written (likely from the Event Formatter) has an addition new line character at the end when it shouldn’t.

When an exception occurs during the callback handler and the exception is set on the task, the task does not release correctly on the awaited task.

Currently the Default exception policy is to throw a NotSupportedException when the OS being used isn’t compatible with the DotRas version being used.

This exception does not seem accurate as it is supported, just not on this OS version.

Suggesting to throw an OperatingSystemNotSupportedException or similar class to indicate this specific issue.

Because so much within the project has changed from V1 to V2 a README file needs to be included with a list of what has changed that can be displayed on installation.

This will need to display:

• Feature differences
• Call differences between versions of the API
• Identifying support for Windows 10
• Identify the project and how to request new features.
• Identify that features will require testers if they are something I cannot build without help.

The 1.x API has a GetProjectionInfo method on RasConnection and will need to be added to reach parity with the older versions.

This will clear a couple issues within the console runner tool that isn't production quality code. The tool is really for development, not actual use.

Between version 1.X and 2.0 there has been a significant change to the primary methods expected to be used on the public RasDialer and RasConnection classes.

RasDialer

• Dial and DialAsync have now been renamed to Connect and ConnectAsync.
• DialAsyncCancel has been removed in favor of using a cancellation token passed to the Connect/ConnectAsync methods (which can accommodate timeouts with a CancellationTokenSource).
• Timeout property has been removed (for the same reason stated above).

RasConnection

• HangUp has been renamed to Disconnect and DisconnectAsync.

They're both viable names, however between the two developers are more accustomed to seeing Connect / Disconnect throughout their other tooling, so the standard names would likely be easier to find. However, that also means 2.0 will not be backwards compatible with 1.X when upgrading.

Currently the DotRas SDK follows the Microsoft naming conventions within the Win32 RAS APIs.

Thoughts? Suggestions?

Just need to get the ReadMe file in master updated to point to the YouTube channel and the Twitter feed.

http://www.youtube.com/user/DotRasProject
http://twitter.com/DotRasProject

Upon further investigation, the error code -2143157998 appears to be defined in EapErrorHost.h as EAP_E_USER_NAME_PASSWORD_REJECTED.

Originally posted by @jeff-winn in https://github.com/winnster/DotRas/issue_comments#issuecomment-450007594

Hello Jeff,
Just noticed this repo :) Seems like you back to DotRas development. Does it mean it will be revised version of DotRas soon?
Could you disclosure some info about it? Is it will be available for public/commercial use, will it work on Win7+ and any Windows 10 versions, and do you have plans to support periodical updates/synchronize with latest Windows SDKs?

Thanks,
Maxim.

The GetStatus method currently has this information, suggesting to add ErrorCode with the dwError field being fed into it upon retrieval of the RASCONNSTATUS.

This item is related to #80 as the dwError field could be used to determine why the connection had been disconnected.

The API currently just provides some basic information about which connection happened to change states when it's processing. However, there is no information exposed that identifies why the connection was disconnected.

Calling HangUp always closes all referenced connections, even if only one connection should be closed.

G'day,

I've got an SSTP VPN connection and I can find it connected in enumerated connections, However the Get Status throws the following error, I had a little look, but couldn't find where the Unknown type is coming from, I'm guessing it just isn't supported at the moment.

Connection statistics works, So I'll use connected time in the mean time as that works

The endpoint type 'Unknown' is not supported.
at DotRas.Internal.Services.IPAddressConversionService.ConvertFromEndpoint(RASTUNNELENDPOINT endPoint) in C:\Repo\Expanded Libraries\DotRAS-Updated\src\DotRas\Internal\Services\IPAddressConversionService.cs:line 17
at DotRas.Internal.Services.Connections.RasGetConnectStatusService.CreateLocalIPAddress(RASCONNSTATUS rasConnStatus) in C:\Repo\Expanded Libraries\DotRAS-Updated\src\DotRas\Internal\Services\Connections\RasGetConnectStatusService.cs:line 67
at DotRas.Internal.Services.Connections.RasGetConnectStatusService.GetConnectionStatus(IRasConnection connection) in C:\Repo\Expanded Libraries\DotRAS-Updated\src\DotRas\Internal\Services\Connections\RasGetConnectStatusService.cs:line 38
at DotRas.RasConnection.GetStatus() in C:\Repo\Expanded Libraries\DotRAS-Updated\src\DotRas\RasConnection.cs:line 135

As per issue on stack overflow, the combination of RequireMSEncryptedPassword and UseLogOnCredentials must be used together in order to login with the current Windows user.

https://stackoverflow.com/questions/54039890/use-windows-login-credentials-on-dotras-vpn-connection

The RasDialer currently does not cancel a connection attempt that is in progress if the class is disposed while busy.

The expected behavior would be to cancel the connection attempt in progress prior to dispose being completed as this can cause state management issues within RAS if it is not performed.

There's a couple sonar warnings that need to be corrected.

There appears to be an issue with the dialer related to IKEv2 connections which are not able to dial when used by the API whereas it still works when dialed by Windows directly.

I use your dotras for a long time
1.Although your DLL has versions of different OS, it doesn't seem to matter if you mix them up?
2. do you plan to release the new version? when

thanks

The usage is quite simple. We have vpn connection with corresponding handle. Our goal is detect unexpected vpn disconnection and perform specific actions on that event.

Yes, sure, I'll test it.

Originally posted by @mogikanin in #2 (comment)

Hello Jeff,

I've started investigating the DotRas project today and cannot understand the build configuration separation for three different platforms.

Conditional compilation symbols are defined but apparently not used anywhere in the code.

Could you please elaborate?

I'm not sure if this is your scope problem or is it window's, but maybe you can answer me.

So user has to install a certificate in order to connect to some server. Let's say server host is myhost.com and it's IP is 111.111.111.111. The certificate is made to be valid for host myhost.com and when connecting to myhost.com everything works, but when connecting to host's IP 111.111.111.111 DotRas throws an error that certificate is invalid.

Is it DotRas scope issue or it's more low-level issue? Cause there is no such problem on Apple or Android.

The 1.x version supported GetNapStatus method and will need to be added to reach feature parity.

This method should be a Windows 8 and higher option.

The Subscribe method is currently missing a guard for the object being disposed.

The RasDial operation may require cancellation by hang up outside of the callback being executed by Windows.

If the target server doesn’t respond when appropriate the client could get stuck and never return. This would cause a deadlock and the consuming application to be blocked until the server responds even if a cancellation token is used with a cancellation source.

Ensure that once a dial operation has begun, cancellation can occur even if the callback does not get invoked.

This behavior should throw an OperationCanceledException as expected back to the DialAsync method on RasDialer.

Saw an issue with NordVPN that if cancellation is triggered, the connection is cancelled but the task being awaited is never returned.

Seems that there is an additional step required to transition the completion source if the token is cancelled.

The RasPhoneBook class is currently missing and will need to be added to reach feature parity with 1.x.

However this will also require clean up as the previous API felt a little weird working with it.

• Implement a change tracker and SaveChanges method to persist changes.
• Try to consolidate the numerous methods exposed to use properties instead.
• May need to leverage Castle.Core to help with proxy implementation for change tracking.

The RasDialer class appears to be able to support changing passwords during a connection attempt if the connection is reattempted from a PasswordExpired state.

See the following for more information:
https://msdn.microsoft.com/en-us/library/windows/desktop/aa377238(v=vs.85).aspx

"Use szPassword to send a new password to the remote server when you restart a RasDial connection from a RASCS_PasswordExpired paused state."

As described, the NuGet package generated during the build pipeline must identify the license being used by this GitHub repository.

With the class being a touch point for most of the interactions with the connection, there will be an expectation of lots of different services available.

As such, rather than passing them all in for the one method call where they're used, it would be better to use service location to grab an instance. Any services that require a particular instance of the connection (perhaps they're stateful) would reside on the connection permanently.

The MyGet.org feed currently requires manual intervention for deploying packages. This step should be automated awhile retaining the manual step to promote the packages to NuGet.org.

After a RasConnection has been established if the connection is disrupted the exception thrown changes from a RasException (by the other methods on the class) to a Win32Exception indicating the handle is invalid.

The expected exception that is thrown should be a RasException with an error code of 668 indicating that the connection has been terminated rather than a Win32Exception with an error code of 6 indicating the handle is invalid.

For components which receive event notifications from the OS (like RasDialer and RasConnectionWatcher) the threads will need to be marshaled correctly back to the UI thread for the UI to update correctly.

The 1.x version has a GetSubEntryHandle method exposed on RasConnection and will need some variation added to reach feature parity.

Perhaps a RasConnectionLink class needs to be added instead to prevent direct manipulation of the handles?

You forgot to mention 2 more exception types in xml doc for DialXXX() methods: ObjectDisposedException (from GuardMustNotBeDisposed()) and FileNotFoundException/RasEntryNotFoundException (from ValidateConfigurationPriorToDialAttempt()).

Originally posted by @mogikanin in #2 (comment)

Need to add support for PPP authentication cookies during a dialing request. This should involve the fSkipPppAuth flag on the RASDIALEXTENSIONS structure along with adding .NET based implementation of the RASDEVSPECIFICINFO structure.

Potential class name: PppAuthenticationCookie
Requires storage of a byte array of unknown size.

https://msdn.microsoft.com/en-us/library/windows/desktop/aa377029(v=vs.85).aspx
https://docs.microsoft.com/en-us/windows/desktop/api/ras/ns-ras-tagrasdevspecificinfo

The RasDialer class needs to have the InterfaceIndex added as it is present in 1.x.

Originally posted by @mogikanin in #2 (comment)

The RasDialer should be able to support EAP based authentication with custom EAP data. If basic credentials are only used, this work item does not apply.

See the RASDIALEXTENSIONS structure for the RasEapInfo.

• If we specify incorrect username, then RasDialer.DialAsync() throws RasException with NativeErrorCode= 691. That's correct.
• But if we specify incorrect password, then occurs generic exception:

System.ArgumentException: The error code must be a positive value.
Parameter name: errorCode
   at DotRas.Internal.Services.ErrorHandling.RasGetErrorStringService.GetErrorString(Int32 errorCode)
   at DotRas.Internal.Policies.DefaultExceptionPolicy.Create(Int32 error)
   at DotRas.Internal.Services.Dialing.DefaultRasDialCallbackHandler.GuardErrorCodeMustBeZero(Int32 errorCode)
   at DotRas.Internal.Services.Dialing.DefaultRasDialCallbackHandler.OnCallback(IntPtr dwCallbackId, Int32 dwSubEntry, IntPtr hRasConn, UInt32 message, RasConnectionState connectionState, Int32 dwError, Int32 dwExtendedError)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at ConsoleRunner.Program.<ConnectAsync>d__8.MoveNext() 

Originally posted by @mogikanin in #2 (comment)

I'm getting exception just after I get IAuthNotify state two times in a row (should I get it two times?).
Exception: RasException (ErrorCode = 13801) DotRas.RasDialException: Exception of type 'DotRas.RasDialException' was thrown.
And that's it...

Originally posted by @NikasZalias in #73 (comment)

Windows does appear to work, however the test NordVPN account does not appear to be functional.

The indicators should identify AppVeyor as the build setup along with SonarCloud.io for code quality analysis.

Need to add support for enumerating RAS capable devices using the Win32 API. This should likely return an IEnumerable with it yielding objects returned from the internal device factory.

RasEnumDevices:
https://docs.microsoft.com/en-us/windows/desktop/api/Ras/nf-ras-rasenumdevicesa

The phonebook path is now required to be set whereas it should not be required.

Need another example which demonstrates the use of the RasDialer in conjunction with the RasConnectionWatcher to monitor for disconnects related to a specific connection.

• Dial the connection
• Attach the new connection to the RasConnectionWatcher
• Start the watcher
• Redial the connection on disconnect

@jeff-winn
Hi jeff-winn ,when I use your component DotRas ，I found many version such as DotRas.Win10 ,DotRas.Win8 ......,does that means only the special OS we can used on it?

The examples need to move into a separate repository rather than this one. This will ensure others can more easily contribute changes without cluttering the main repository.

Hi,

I have an IKEv2 RAS Entry with EAP-TLS SmartCard Authentication.
Due to testing limitations, the SmartCard is forwarded with RDP to the PC running the Software.
If I dial this entry with rasphone -d entry the SmartCard-PIN-Dialog shows up and the connection gets established after entering the PIN.

With DotRas I get an Exception that the "Smartcard-Resource-Manager is not running":
System.ComponentModel.Win32Exception (0x80004005): Der Smartcard-Ressourcen-Manager wird nicht ausgeführt

The same code and entry works locally, if I don't use a forwarded SmartCard.

I verified winscard finds the forwarded SmartCard and as mentioned above rasphone works.

Any Ideas what might be missing in DotRas that it seems not to be able to use forwarded SmartCards?

Installed Version: id="DotRas.for.Win10" version="2.0.0-preview-275" targetFramework="net472"

Thanks in Advance

Per Microsoft, calls to RasDial must be call RasHangUp when a non-zero response is returned from the API call. This call is currently missing from the RasDialService while it is being done within the DefaultRasDialCallbackHandler.

The internal dependency injection container currently only issues out a single instance of an object for use across the entire app domain. This causes only a single instance to be usable at a time for a particular component without causing state issues.

The expected behavior of the container was to provide unique instances per type resolved rather than singletons.