[Bug]: `ResolveKeySource` is not a dependency of `CoreCompile` about msbuild HOT 3 OPEN

In that binlog:

1. CoreCompile is running because of <Target Name="_SetGeneratedOutputItems" DependsOnTargets="CoreCompile"> from microsoft.visualstudio.extensibility.jsongenerators.sdk\17.10.2079\build\Microsoft.VisualStudio.Extensibility.JsonGenerators.Sdk.props
2. That's depended on by ExtensionJsonOutputGroup
3. That's explicitly requested in the reference through VSSDK targets by

https://github.com/dotnet/roslyn/blob/879be6a9604d74f51916939625856e6602303256/src/VisualStudio/Setup/Roslyn.VisualStudio.Setup.csproj#L209C146-L209C170

I think two things should be done:

1. The VSSDK should be updated so that reference is Compile instead of CoreCompile, which would trigger all of $(CompileDependsOn) in order and work.
2. CoreCompile for VB and C# should consider adding an explicit dependency on ResolveKeySource.

The reason I'm saying "consider" for 2 is that right now CoreCompile doesn't really have any explicit dependencies and depends on the implicit $(BuildDependsOn)/$(CompileDependsOn) ordering. That can produce other problems like this (I'm a bit surprised for example that NuGet references made it into this compilation)--but adding a constraints to target order has been a surprisingly breaking operation in the past due to how people have hooked the fragile existing system.

from msbuild.

• The VSSDK should be updated so that reference is Compile instead of CoreCompile, which would trigger all of $(CompileDependsOn) in order and work.

I did this in an internal PR that I just completed; not sure when there'll be a new package for Roslyn to reference @jjonescz.

from msbuild.

Thanks, now after updating VSSDK with the fix I see a similar issue - WPF markup is not getting compiled. Again it looks like target CoreBuild depends on PrepareResources which depends on MarkupCompilePass1 and CoreCompile is not in this dependency chain so it can run before MarkupCompilePass1 - failing to find the C# files generated from WPF XAML markup files.

Here are binlogs - first a failing one then another succeeding on rebuild for comparison: wpf-binlogs.zip

Edit: thinking more about this it's weird the generated files are getting deleted on incremental rebuilds, I should look into that.
Edit2: nevermind, they are not getting deleted, they are just not passed as Compile items.

from msbuild.