Comments (2)
This is a consequence of the ITask
interface. Tasks can return success or failure by the bool return value of Execute()
, and independently they can log errors. Unfortunately, that means you can say
Log.LogError("Catastrophic failure");
return true; // "Task succeeded"
And unfortunately that's basically what we do for the fragment type of inline code (add return true;
after the user-specified code).
We should consider adopting the preferred pattern (return !Log.HasLoggedError;
) in our generation around here:
msbuild/src/Tasks/CodeTaskFactory.cs
Lines 390 to 401 in 85d1d66
and also in RoslynCodeTaskFactory
msbuild/src/Tasks/RoslynCodeTaskFactory/RoslynCodeTaskFactory.cs
Lines 226 to 239 in 85d1d66
from msbuild.
good bug!
from msbuild.
Related Issues (20)
- [Testing][GangWang01]: Testing effort of BuildCheck HOT 2
- [Testing][JaynieBai]: Testing effort of BuildCheck
- [Bug] Args type resolution in Expander HOT 2
- Add missing Evaluator FastPath items for common SDK use cases HOT 2
- [SDK] Add test verifying no fast path evaluators are not needed by SDK
- [Bug]: BuildCheck - building the solution with two projects that don't share the same output/intermediate output path has BC0101 warning
- ToolLocationHelper property functions require reflection
- [Bug]: PerformanceSummary console logger parameter doesn't show anything with terminal logger enabled HOT 3
- [Bug] [BuildCheck]: rebuild with the build-in analyzers hangs
- [Feature Request]: Design and implement progress messages API
- [Feature Request]: Make Exec task support new progress messages.
- Document `RegisterTaskObject` ignoring `allowEarlyCollection`
- [Bug] [BuildCheck] [Documentation]: Default severity of build-in analyzer rules should be documented.
- [BuildCheck][FeatureRequest] Env variable BuildCheck reports value
- [Bug]: Culture used when formatting Date changed in PropertyGroup HOT 7
- [Bug] [BuildCheck]: BC0103 used environment variable does not trigger when property is defined in target
- Invalid Zero Length check expression
- Property functions with a single `_` as an argument return bad results
- [Unhandled Exception]: Exception of type 'System.OutOfMemoryException' was thrown HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from msbuild.