Next Release for Microsoft.Data.SqlClient about ef6 HOT 20 CLOSED

@ladeak just use my well tested and supported runtime package, you could be in for a long wait. https://www.nuget.org/packages/ErikEJ.EntityFramework.SqlServer

from ef6.

@ladeak Indirectly? (Just a sample of an isolated test that now fails, and did not before)

from ef6.

@ladeak a 6.5 preview package is available now

@ajcvickers @SamMonoRT feel free to close this, no repro code provided and it relates to my project, not this

from ef6.

/cc @SamMonoRT

from ef6.

I have tried both using https://www.nuget.org/packages/ErikEJ.EntityFramework.SqlServer from @ErikEJ and building this repository.
When I built the main branch of this repository, I noticed a few "breaking" changes that were captured by unit tests, but they were mostly on some arguments being validated against null values or some types now require Database.SetConfiguration(...) call. Nothing that could not be worked around.

from ef6.

@ladeak Can you share more details? Maybe something that needs to be fixed?

from ef6.

Sure, let me come back to this on Monday.

from ef6.

1. DbFunctionCommandTree requires a non-null MetadataWorkspace argument
2. DbContext.ChangeTracker.DetectChanges() requires Database.SetConfiguration() to be invoked upfront.

Note, that the same changes are not required when using ErikEJ.EntityFramework.SqlServer package, but only when I try to build EF6 from the main branch.

from ef6.

@ladeak Could you share a log or call stack?

from ef6.

DbFunctionCommandTree is straightforward, it throws in the base ctor (DbCommandTree).

ChangeTracker.DetectChanges() goes as

• InternalContext.DetectChanges
• LazyInternalContext.DetectChanges
• InternalContext.Initialize
• LazyInternalContext.InitializeContext
• RetryLazy...GetValue
• LazyInternalContext.CreateModel
• DbModelBuilder.Build
• Provider Connection.GetProviderInfo

from ef6.

@ladeak Sorry, I do not follow - is this when you build the Microsoft.EntityFramework.SqlServer project locally?

from ef6.

When I build the main branch of EF6 locally with Microsoft Entityframework.SqlClient enabled and use it as a package, then some of my unit tests are breaking at test execution time with exceptions that were previously not present.
I had workaround for all of them in my tests, but I thought it might worth bringing this up.

from ef6.

@ladeak Are you abe to share the failing tests? Maybe it is something that need to be fixed in the new EF Provider?

from ef6.

I am afraid I cannot share the code directly.

from ef6.

The first case is relatively simple in a unit test:

new DbFunctionCommandTree(null, ... );

the second case is a bit trickier to describe: we create custom DbContext and invoke one of its methods which eventually calls ChangeTracker.DetectChanges() in the unit test.

from ef6.

Closing as per comment above.

from ef6.