Thread.CurrentThread.CurrentCulture settings are leaked into the generated SQL causing invalid SQL about ef6 HOT 7 CLOSED

what happens if you do not use a constant?

from ef6.

It will work as EF will parameterize the SQL query. If nothing else, it is a work-around that can be used.

from ef6.

@osjoberg Cool, do not expect any bug fixes to EF6!

from ef6.

I see that this has been reported before so I guess it will not be fixed.

If anyone have any insight onto why the behaviour differs between .NET Framework 4.8 and .NET8 I would be interested to know.

Are there any other issues that can arise from having Thread.CurrentThread.CurrentCulture set?

from ef6.

This issue has been closed because EF6 is no longer being actively developed. We are instead focusing on stability of the codebase, which means we will only make changes to address security issues. See the repo README for more information.

from ef6.

@osjoberg My understanding is that CurrentCulture will affect the SQL generated in both net48 and net8, and it should be set to match the locale of your SQL server.
This can also affect your persistence data when serializing/deserializing.
You can use CurrentCultureUI for formatting strings etc. for your end user to differentiate between the two.

from ef6.

@CZEMacLeod Im pretty sure this is an error only in EF6/.NET7 as this error was found when porting a large system from .NET Framework 4.8 to .NET7. I have created two different console applications with the repro above one for .NET Framework 4.8 and one for .NET7. where the .NET Framework console application works, the .NET7 version throws an exception while trying to execute the invalid SQL.

I belive it is correct of my system to set CurrentCulture to present curerncies, dates etc. in a localized fashion. In this legacy system it has had no other side effect until now.

from ef6.