dotenv-org / phpdotenv-vault Goto Github PK

Hi,

it is not possible to call phpdotenv methods like:

$dotenv = DotenvVault::createImmutable(__DIR__, '.env.vault');
$dotenv->load();

$dotenv->required('DATABASE_DSN');

Throws:
Repository is not set

Solution:

public function __construct(
        StoreInterface $store,
        ParserInterface $parser,
        LoaderInterface $loader,
        RepositoryInterface $repository
    )
    {
        $this->store = $store;
        $this->parser = $parser;
        $this->loader = $loader;
        $this->repository = $repository;
        parent::__construct($store, $parser, $loader, $repository);
    }

Hi,

if there is no DOTENV_KEY phpdotenv-vault fallback to the unencrypted .env file.
In this case there is a var_dump on first .env entry (ref)

var_dump($entries[0]->getName());
var_dump($entries[0]->getValue());

If there should be an output, it would be better to add a notice or warning so that it can be ignored by error_reporting.

trigger_error('Fallback to unencrypted .env', E_USER_NOTICE);

Hi,

after updating to package version 0.1.2, phpdotenv-vault throws:
NOT_FOUND_DOTENV_ENVIRONMENT: Cannot locate environment DOTENV_VAULT_DEVELOPMENT in your .env.vault file. Run 'npx dotenv-vault build' to include it.

PHP: 8.2
phpdotenv-vault: 0.1.2

In my opinion the problem is, the last change Use getenv instead of

Why?
We load our .env with the following code:

$dotenv = DotenvVault::createImmutable(__DIR__, '.env.vault');
$dotenv->load();

The function createImmutable calls RepositoryBuilder::createWithDefaultAdapters(). The used default adapters are ServerConstAdapter and EnvConstAdapter (ref vlucas/phpdotenv/src/Repository/RepositoryBuilder.php).
These adapters write our environment variables to $_SERVER and $_ENV. So with these adapers we can't access our variables via getenv. The needed PutenvAdapter is only added inside createUnsafeImmutable.

How to deal with it?

Hi,

the class name is written in CamelCase so the current readme example:

Should be look like:

use DotenvVault\DotEnvVault; 
require 'vendor/autoload.php'; 
  
$dotenv = DotEnvVault::createImmutable(__DIR__, '.env.vault'); 
$dotenv->load(); # take environment variables from .env.vault 

Writing a library for PHP but requiring Node.Js (The NPX)? Why not using PHP's in built system?