dorba / netcoreaudio Goto Github PK

Hello @dorba,

I wanted to check with you as to what license this code is under? I was considering using it in a commercial project, and wanted to make sure this is OK first, but couldn't find anything in the repository.

Thanks!

Hello,

It appears that the GUID specified in PropertyKeys.cs for PKEY_DeviceInterface_FriendlyName is incorrectly named, as it is actually PKEY_Device_xxx.

Additionally, the two other common device PropertyKey GUIDs are absent, as found in the Microsoft docs. They are PKEY_DeviceInterface_FriendlyName(the actual one), and PKEY_Device_DeviceDesc.

I believe the corrected/added values are as follows:

PKEY_Device_FriendlyName = new Guid(0xa45c254e, 0xdf1c, 0x4efd, 0x80, 0x20, 0x67, 0xd1, 0x46, 0xa8, 0x50, 0xe0); // PID 14
PKEY_DeviceInterface_FriendlyName = new Guid(0x026e516e, 0xb814, 0x414b, 0x83, 0xcd, 0x85, 0x6d, 0x6f, 0xef, 0x48, 0x22); // PID 2
PKEY_Device_DeviceDesc = new Guid(0xa45c254e, 0xdf1c, 0x4efd, 0x80, 0x20, 0x67, 0xd1, 0x46, 0xa8, 0x50, 0xe0); // PID 2

Side note, I don't see anywhere where the PID values are defined. Is this intentional? The information currently given in PropertyKeys.cs isn't actually enough to uniquely identify the properties without the user referencing PID values from the Windows API headers. (e.g. the GUIDs for Device_FriendlyName and Device_DeviceDesc are the same, you need the different PID values in order to actually get the right info)

Would it be possible to publish you're great work as a nuget package so it can be easily imported for other projects.

I'm currently working on an extension for a WM called workspacer. This provides visual feedback in the form of a configurable widget about a chosen sound device and the control of it with custom key bindings. You can check out my work here

Thanks in advance, if i can be of any help let me know