dopesong / slim-whoops Goto Github PK

If I add a bunch of my custom handlers like so:

$whoopsHandler = new WhoopsError();
$whoopsHandler->pushHandler(new LoggerAwareHandler($logger));
$whoopsHandler->pushHandler(new ApiExceptionHandler());

They will be ignored.

This happens because

1. Content type handler is the last handler that is pushed to the internal whoops object
2. Handler collection is iterated over in reverse

This means that the handler that was pushed last will always be the first.

One way to solve this would be to add all handlers in reverse.

The initial example shows a boolean being passed to the constructor:

$container['phpErrorHandler'] = $container['errorHandler'] = function($c) {
    return new WhoopsError($c->get('settings')['displayErrorDetails']);
};

While the constructor itself has no parameters.

I'd suggest the minor change to the example:

$container['phpErrorHandler'] = $container['errorHandler'] = function($c) {
    return new WhoopsError();
};

However this does raise the question, how best to display the whoops error page versus an end-user safe 500 status page on error without the ability to control the display mechanism in the constructor.