Comments (6)
and with 2.
pros
- no need to change view codes
- reuse test code
cons
- possibly need to customize for specific functionality with same query?
please let me know how you guys think about it
I think this second one is already "nicely" implemented (btw, it's also AWS Amplify codeGen style, too) on signUp, signIn, and verifyEmail using
useMutation
and is clearly beneficial when it comes to reusing the query
Okay that sounds good! I would like to give it a try!
from hackatalk.
and with 2.
pros
- no need to change view codes
- reuse test code
cons
- possibly need to customize for specific functionality with same query?
please let me know how you guys think about it
I think this second one is already "nicely" implemented (btw, it's also AWS Amplify codeGen style, too) on signUp, signIn, and verifyEmail using useMutation
and is clearly beneficial when it comes to reusing the query
from hackatalk.
So we have two options to implement apollo client here
- put apollo code inside of view component and thus remove unnecessary provider
- put apollo code inside of provider
let's discuss of pros and cons here
if we choose 1.
pros
- easy to customize apollo client code for view specific code
- remove unnecessary provider codes
cons
- removed encapsulation for side effect codes (provider)
and with 2.
pros
- no need to change view codes
- reuse test code
cons
- possibly need to customize for specific functionality with same query?
please let me know how you guys think about it
from hackatalk.
@hyochan I added task called delete friend
in Search users / add friends / show friends
section.
User might want to delete a friend someday after the user adds some user to friend list.
please let me know if this delete friend
task has not been intended.
from hackatalk.
@geoseong You're right! I've added that for you!
from hackatalk.
Closed followed by #134
from hackatalk.
Related Issues (20)
- bug: wrong spec for multiple files upload HOT 2
- inline dotenv does not work any longer
- Clickable Links / URL HOT 2
- Improve a signIn function to validate a email & password correctly HOT 1
- login page animation starting location issue HOT 3
- Implement a feature which can invite friends in chatroom. HOT 1
- Editing message should be saved when left the room. HOT 8
- bug: an error alert pop-ups when click "메일 재전송" button HOT 2
- Improvement of notifying sign in error HOT 7
- Status message could be overflowing text content area HOT 3
- License Agreement Message is hidden in website. HOT 5
- Create empty channel (Self Chat?) HOT 3
- Delete messages feature HOT 3
- Delete same channel notification if enter the chat channel. HOT 4
- Old relay types are being used
- Tag users
- Upload movie clip in [Message] HOT 4
- Voice message
- File Upload
- Sunset Alert: Attention Required!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hackatalk.