Giter Club home page Giter Club logo

Comments (6)

godon019 avatar godon019 commented on May 26, 2024 2

and with 2.

pros

  • no need to change view codes
  • reuse test code

cons

  • possibly need to customize for specific functionality with same query?

please let me know how you guys think about it

I think this second one is already "nicely" implemented (btw, it's also AWS Amplify codeGen style, too) on signUp, signIn, and verifyEmail using useMutation and is clearly beneficial when it comes to reusing the query

Okay that sounds good! I would like to give it a try!

from hackatalk.

marsinearth avatar marsinearth commented on May 26, 2024 1

and with 2.

pros

  • no need to change view codes
  • reuse test code

cons

  • possibly need to customize for specific functionality with same query?

please let me know how you guys think about it

I think this second one is already "nicely" implemented (btw, it's also AWS Amplify codeGen style, too) on signUp, signIn, and verifyEmail using useMutation and is clearly beneficial when it comes to reusing the query

from hackatalk.

godon019 avatar godon019 commented on May 26, 2024

So we have two options to implement apollo client here

  1. put apollo code inside of view component and thus remove unnecessary provider
  2. put apollo code inside of provider

let's discuss of pros and cons here

if we choose 1.

pros

  • easy to customize apollo client code for view specific code
  • remove unnecessary provider codes

cons

  • removed encapsulation for side effect codes (provider)

and with 2.

pros

  • no need to change view codes
  • reuse test code

cons

  • possibly need to customize for specific functionality with same query?

please let me know how you guys think about it

from hackatalk.

geoseong avatar geoseong commented on May 26, 2024

@hyochan I added task called delete friend in Search users / add friends / show friends section.

User might want to delete a friend someday after the user adds some user to friend list.

please let me know if this delete friend task has not been intended.

from hackatalk.

hyochan avatar hyochan commented on May 26, 2024

@geoseong You're right! I've added that for you!

from hackatalk.

hyochan avatar hyochan commented on May 26, 2024

Closed followed by #134

from hackatalk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.