bug: an error alert pop-ups when click "메일 재전송" button about hackatalk HOT 2 CLOSED

Does it work when you first sign up in your localhost?
I mean when you first try to sign up, verifying email sent to your email address well?

actually to test this email send in localhost, you need to configure your own SendGrid account and configure SENDGRID_API_KEY, SENDGRID_EMAIL prop in the server/dotenv/.env file.

SENDGRID_EMAIL is the email address like [email protected]. so If you have configured your own sendgrid account, you need to put your email address to SENDGRID_EMAIL.

related sendgrid documentation:
Step 1. Create your account
Step 2. Creating an API key
Step 3. How to set up domain authentication

and also I found some bug in server code related to this issue. so you can fix and create PR on it. 👍

look at the mutation.ts.

• the parameter "from" in SendGridMail.send() method in the two resolver sendVerification and findPassword have different value.
  • one (sendVerification) is SENDGRID_EMAIL variable from process.env,

      const msg: MailDataRequired = {
        to: email,
        from: SENDGRID_EMAIL, <<-------
        subject: ctx.request.req.t('VERIFICATION_EMAIL_SUBJECT'),
        html,
      };
  
      await SendGridMail.send(msg);
  

  • and the other(findPassword) is just string value([email protected]).

    const msg = {
      to: email,
      from: '[email protected]', <<------- need to be changed to 'SENDGRID_EMAIL' or SENDGRID_EMAIL || '[email protected]'
      subject: ctx.request.req.t('PASSWORD_RESET_EMAIL_SUBJECT'),
      html: getPasswordResetHTML(verificationToken, password, ctx.request.req),
    };
  
    try {
      await SendGridMail.send(msg);
  

I think the parameter in findPassword resolver should be replaced with SENDGRID_EMAIL variable for consistency.

I created my own sendgrid account and tried to replace the from param with my own email address in SendGridMail.send(), it worked well. please refer to it.

from hackatalk.

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

from hackatalk.