dontpanicux / prj-rev-bwfs-dasmoto Goto Github PK

Good job specifying the span css selector class and good choice of name. Clear and concise names are the best. This gives you more flexibility as your code grows in size and makes your code more reusable since if you need to do similar highlighting in the future, you can just reference this again.

https://github.com/dontpanicux/prj-rev-bwfs-dasmoto/blob/master/project_dasmotoArtCrafts/index.html#L34

Try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. So next time, save all the images under resources/images/

https://github.com/dontpanicux/prj-rev-bwfs-dasmoto/blob/master/project_dasmotoArtCrafts/index.html#L25

Summary Grade: Exceeds Expectations

Good job with your code! I really like the use of indentation and whitespace in your html code! Makes your code very easy to read! Also, good decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code. Great start to the Ready program!

I included a few notes in both the html and css files for you to think more critically about. First, try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. Also, your lines are a bit long right now. Try splitting this into new lines so it's easier to read on one screen without scrolling. Convention is usually ~79 characters per line.

Your lines are a bit long right now. Try splitting this into new lines so it's easier to read on one screen without scrolling. Convention is usually ~79 characters per line. It’s an issue of code density. Programmers like to have a lot of context when reading code. It is much, much quicker to glance up and down a window than it is to scroll. If you have very long lines, you also tend to have lines that vary in length a lot, leading to a lot of wasted screen real estate and being able to fit less code on screen at a given time overall.

https://github.com/dontpanicux/prj-rev-bwfs-dasmoto/blob/master/project_dasmotoArtCrafts/index.html#L41

I really like the use of indentation and whitespace! Makes your code very easy to read! Keep up the great work.

https://github.com/dontpanicux/prj-rev-bwfs-dasmoto/blob/master/project_dasmotoArtCrafts/index.html#L1