doncabreraphone / victorhugo Goto Github PK

Ola Javier, just few things :

• {{ if eq .Params.clean "true" }}{{ else }} should read {{ if eq .Params.Victor_Hugo_Clean "true" }}{{ else }}
• Or better : {{ if eq site.Params.Victor_Hugo_Clean "true" }}{{ else }} so you give this parameter only once in your config.toml
• According to this code, your README should read :
  • Victor_Hugo_Clean: accepts true or false. If true, it will not import jQuery. If it is set to false, it will import jQuery.

And more generally, are you thinking about adapting it for not only simple pages (blog) but also for the main index.html ?
Because I have a web site on one page and it doesn't work (i did not dig yet in the code to find the problems).

Thanks anyway.

Have you considered making victorhugo into a Hugo Module? Some examples of this in action are at https://github.com/gohugoio/hugo-mod-jslibs. I think it might make victorhugo even easier to hook into a web site; it will allow users to more easily keep their version of victorhugo up-to-date; and it will likely mean you can modify victorhugo in ways that could make it more maintainable, rather than have it continue to be one big file.

First thanks for developing this :D

the victorhugo_google_snippet does not support running on the front page, because, in line 1449 it says {{ $victorhugo__slug := substr $victorhugo__slug 1 200 }} // ignoring the first character and then takes the next 200 this is not working if the page is the frontpage because then the slug is / and ignoring the first char will leave the string empty.

Hello. Well done! And thank you.

Here are a few issues that I noticed while getting this working:

• My site uses the defer attribute on the <script> tag that loads jQuery, which means jQuery is not loaded before inline Javascript, which meant initially that victorhugo was broken on my site. I fixed this by changing this line to instead say window.addEventListener('DOMContentLoaded', function(){, which removes the dependency on jQuery until after it has loaded, even if it is marked defer.
• victorhugo fails completely if the <meta name="description"> tag is missing entirely. In my case, I had included the partial {{ template "_internal/schema.html" . -}}, which has itemprop as its attribute instead of name. Not sure what the difference is, but ideally this wouldn't cause the code to fail entirely.

Once I resolved these two issues, victorhugo is very informative.

Greetings,

I have just installed this Hugo partial, MANY thanks for writing it.

I have found two bugs so far, one easily solvable, the other I don't know.

The first is that the regex that counts the subheadings should change from

'<h2>' to '<h2 ' (or even '</h2>'?)

Otherwise it will NOT recognize subheadings with attributes, as it happens with my current theme, which generates headings like:

<h2 id="Conclusions">Conclusions</h2>

The other problem is much harder for me to investigate and fix. The Flesch reading ease formula seems really broken. It returns -17, or 17, but if I copy the same text from the browser to a text editor, save it as testing.txt, and feed THAT file to the Flesch tool at http://flesh.sourceforge.net/ , it returns 51.

Of course, even that tool may be buggy, but... 17? No way. The sample text is not THAT hard to read, for sure. 51 is way, way more realistic.

I can provide the raw markdown file that generates that result, but I would rather not leave it here on github. To have it and test, pls email [email protected], thanks.