dolejska-daniel / riot-api-base Goto Github PK

Hey , I'm Getting this error after updating to version 5.0 and trying to use $api->getTimeline('BR1_123456');
is there anything i can do to fix it ?

Obs: if i try this code after the async it does not work , if i try before the async it works fine.

Originally posted by @Lucasnl in dolejska-daniel/riot-api-league#1 (comment)

There is quite a lot of regions missing support in this lib, some examples:

Specifically These:

Hello,

The v1.1 version is not the latest with my patch inside it.
Could you please tag a new version ?

Tahnks

Hello, was there any change with the way asynchronous requests are done on the latest meta package?

I've recently tried migrating my project from riot-api v4.1 to riot-api-base + riot-api-league v1.0. The synchronous requests seem to work correctly, however the promise do not seem to resolve when the requests are called asynchronously.

Here's an example of code I was using with the previous version:

       // fetch an ongoing game
        $game = $api->getCurrentGameInfo($summonerId);
        $summoners = [];
        foreach ($participants as $participant) {
           // fetch the league entries for each of the games participants
            $api->nextAsync(
                function ($entryDto) use ($participant): void {
                    //on success add the participants'LP to the summoners array
                    $summoners[$participant->summonerId] = $entryDto->leaguePoints;
                },
                function (Exception $error) use ($participant): void {
                    // otherwise add null
                    $summoners[$participant->summonerId] = null;
                },
                'entries'
            )->getLeagueEntriesForSummoner($participant->summonerId);
        }
        $this->api->commitAsync('entries');

This was working fine with v4.1, but silently fails on v1.0. Any idea what the reason could be ?