Giter Club home page Giter Club logo

Comments (9)

jkeen avatar jkeen commented on May 22, 2024

You can work around this by defining a viewportListeners: [] property on the component, but that doesn't feel right.

from ember-in-viewport.

swalkinshaw avatar swalkinshaw commented on May 22, 2024

Just wanted to report I also ran into the same issue and defining viewportListeners: [] worked.

from ember-in-viewport.

poteto avatar poteto commented on May 22, 2024

The above solution is OK in my book. Testing the "in viewport" behavior is very difficult / non-trivial and I would avoid doing so in your integration test.

from ember-in-viewport.

swalkinshaw avatar swalkinshaw commented on May 22, 2024

@poteto just to clarify, the error occurs when simply rendering a component in an integration test. I personally don't have an issue with just defining viewportListeners though since, in my case, I was overriding them so it kind of makes sense.

import Ember from 'ember';
import InViewportMixin from 'ember-in-viewport';

export default Ember.Component.extend(InViewportMixin, {
  viewportListeners: [],
  viewportOptionsOverride: on('didInsertElement', function() {
    this.setProperties({
      viewportSpy: true,
      viewportListeners: [
        { context: window, event: 'scroll.scrollable' },
        { context: window, event: 'resize.resizable' },
        { context: document, event: 'touchmove.scrollable' }
      ]
    });
  })
});

from ember-in-viewport.

poteto avatar poteto commented on May 22, 2024

Yeah, it fails because the initializer isn't invoked in the integration test. I can add a guard to the mixin in case it is undefined

from ember-in-viewport.

elidupuis avatar elidupuis commented on May 22, 2024

Just ran into this issue myself and made a quick PR (#52).

from ember-in-viewport.

sethbrasile avatar sethbrasile commented on May 22, 2024

Ran into this issue, it was blowing up my mocha tests with undefined is not an object (evaluating 'this.cache.subject') and Assertion Failed: You cannot use the same root element (#ember-testing) multiple times in an Ember.Application

Not sure how it's related, but making @elidupuis' change fixes it.

from ember-in-viewport.

danielleadams avatar danielleadams commented on May 22, 2024

It looks like it's probably the same error because the first one is trying to access the undefined properties (which are set in init). The second is simply because your tests weren't tearing down the setup of the previous test properly due to the initial error.

I had similar behavior and had to created a Mixin inside the application that extended the addon.

from ember-in-viewport.

sethbrasile avatar sethbrasile commented on May 22, 2024

ahhh @danielleadams I hadn't put enough thought into it. I should know to always look at the first error when there are two, but the 2nd seemed more prevalent so I was stupidly focusing on that one. Thanks! Maybe next time it won't take me 2 hours to figure out :D

To anyone ending up here from the google, I just added viewportListeners: [] to the component that is using the mixin.

from ember-in-viewport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.