Comments (5)
jherdman
commented on June 11, 2024
Assertion stems from here
from ember-in-viewport.
snewcomer
commented on June 11, 2024
@jherdman Thx for the issue! The dummy app was just updated to 3.22 and all tests were passing with our built in modifier. Is it still reproducing? A nombom didn't fix the issue for you?
from ember-in-viewport.
jherdman
commented on June 11, 2024
Yeah, it's really easy to reproduce in an app at my company, but I'm
struggling to reproduce it outside of it. It's almost exactly the same
scenario as the modifier acceptable test.
…On Sun, Oct 25, 2020, 17:24 Scott Newcomer ***@***.***> wrote:
@jherdman <https://github.com/jherdman> Thx for the issue! The dummy app
was just updated to 3.22 and all tests were passing with our built in
modifier. Is it still reproducing? A nombom didn't fix the issue for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#258 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAZZDBSZWPTGJQ6G2FWA3SMSJRHANCNFSM4S3MFSRA>
.
from ember-in-viewport.
jherdman
commented on June 11, 2024
I found it. I can't recall how I ended up down this path, but...
$ yarn why ember-modifier
Returns...
=> Found "[email protected]"
info Has been hoisted to "ember-modifier"
info Reasons this module exists
- Hoisted from "ember-sortable#ember-modifier"
- Hoisted from "ember-on-resize-modifier#ember-modifier"
info Disk size without dependencies: "188KB"
info Disk size with unique dependencies: "892KB"
info Disk size with transitive dependencies: "46.72MB"
info Number of shared dependencies: 167
=> Found "ember-in-viewport#[email protected]"
info This module exists because "ember-in-viewport" depends on it.
info Disk size without dependencies: "1004KB"
info Disk size with unique dependencies: "4.9MB"
info Disk size with transitive dependencies: "54.02MB"
info Number of shared dependencies: 184
=> Found "ember-resize-observer-component#[email protected]"
info Reasons this module exists
- "@precision-nutrition#procoach-profile#ember-resize-observer-component#ember-on-resize-modifier" depends on it
- Hoisted from "@precision-nutrition#procoach-profile#ember-resize-observer-component#ember-on-resize-modifier#ember-modifier"
info Disk size without dependencies: "1004KB"
info Disk size with unique dependencies: "4.9MB"
info Disk size with transitive dependencies: "54.02MB"
info Number of shared dependencies: 184
Ah, snap... two versions...
Digging in...
adopted-ember-addons/ember-sortable#383
Ah ha!
All the more reason to dependency lint.
I think we can close this.
from ember-in-viewport.
snewcomer
commented on June 11, 2024
Great! Noting for the future
from ember-in-viewport.
Related Issues (20)
- Changelog HOT 1
- Failing to load more if items dont fill the screen HOT 1
- Pass more data back to callbacks
- Running Very Slowly HOT 9
- onExit doesn't get fired on IE HOT 3
- TypeError: Cannot read property 'viewportConfig' of undefined HOT 4
- Test failure in Ember 3.20
- Use {{in-viewport}} modifier multiple times on a page only trigger the last one's callback HOT 2
- Lazy load rAf implementation HOT 3
- onEvent(callback) API doesn't work HOT 1
- viewportSpy: false triggering onEnter everytime HOT 5
- Add enter/exit logging if enabled
- onExit doesn't fire unless viewportSpy is enabled
- How to access didScroll using service method? HOT 1
- Safari/IOS Flicker Bug
- Update to ember-auto-import@2 HOT 2
- assign is deprecated
- Convert to v2 addon HOT 1
- Support % based rootMargin
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-in-viewport.