dobriak / autoscaler Goto Github PK

Currently, there is no versioning. Needs to be implemented sooner than later.

After running the app for a week with 20 apps, we got the next error

fatal error: concurrent map read and map write

goroutine 1696260 [running]:
runtime.throw(0x710e72, 0x21)
	/usr/local/go/src/runtime/panic.go:596 +0x95 fp=0xc420287630 sp=0xc420287610
runtime.mapaccess1_faststr(0x6b08e0, 0xc420164270, 0xc42016ae20, 0x1b, 0x18)
	/usr/local/go/src/runtime/hashmap_fast.go:217 +0x4cf fp=0xc420287690 sp=0xc420287630
main.(*App).doMonitor(0xc4201ae3f0)
	/home/vagrant/go/src/github.com/dobriak/autoscaler/app.go:43 +0x9d fp=0xc4202877d8 sp=0xc420287690
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2197 +0x1 fp=0xc4202877e0 sp=0xc4202877d8
created by main.(*App).StartMonitor
	/home/vagrant/go/src/github.com/dobriak/autoscaler/app.go:36 +0xa7

RHEL-like systems do not have jq installed out of the box unlike CoreOS. Add this check to the sample_apps.sh.

Currently, the inputs from the REST api are not tested for sanity.

Code needs to be refactored a bit to allow for unit testing

Allow for monitoring of node metrics as well.

Secret name is hardcoded in marathon app definition, but actual secret name is dependent on username provided, so it needs to be parameterized or at least added as documented step.

Steps:

• ./create-service-account.sh username <group>
• secret gets created as as_secret_username
• Now app deployment will fail, because json definition states "source": "as_secret_scaler"

If you're not aware about how the autoscaler is collecting the metrics for an app, you can cause a DDoS to the mesos-agent:

level=error msg="Error unmarshalling TasksStats"
level=info msg="app:/test cpu:NaN, mem:NaN"

Include automated functional tests

• Exercise the REST api
• Test signal producing abilities for cpu, mem, and, or.