When requesting the feed URL, the XML module uses Globals.GetExternalRequest, which uses an outdated request. The GetExternalRequest method is HttpWebRequest and should be changed to use HttpClient https://msdn.microsoft.com/en-us/library/system.net.http.httpclient(v=vs.118).aspx

When requesting secure content, this can cause a transport error. See this related stackexchange: http://stackoverflow.com/questions/35705131/cant-load-dotnetnuke-xml-module-after-security-update-to-tls-1-2

I've come across the same error in the same scenario. I am requesting a feed from a site using TSL 1.2

In lieu of DNN updating the method, the xml module should remove the dependency on the global function and roll with it's own httpclient request.

Describe the bug

When cloning this repository, the project does not load in visual studio due to not being able to find MSBuild.Community.Tasks.Targets

To Reproduce

Steps to reproduce the behavior:

1. Clone the repository
2. Try to open solution in Visual Studio

Expected behavior

Users should be able to clone and build without having to modify solution, project or build scripts.

Error log

Note: Debug DLL's

D:\websites\dnn930\DesktopModules\DNN.XML\DNN_XML.csproj : error  : The imported project "D:\websites\dnn930\DesktopModules\packages\MSBuildTasks.1.4.0.128\tools\MSBuild.Community.Tasks.Targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.  D:\websites\dnn930\DesktopModules\DNN.XML\DNN_XML.csproj

We need issue templates to be consistent with other DNN Community repos.

Does anyone have the same issues? DNN 9.2.2, XML module 6.0.4 (I had the errors with 6.0.2, hoped that a newer version would resolve the issues but it didn't).

ModuleId:568
ModuleDefId:137
FriendlyName:Eindbeoordeling
ModuleControlSource:DesktopModules/XML/XmlModule.ascx
AbsoluteURL:/Default.aspx
DefaultDataProvider:DotNetNuke.Data.SqlDataProvider, DotNetNuke
ExceptionGUID:2c8685bd-a95a-409c-9a63-e0ddb547d176
AssemblyVersion:9.2.2
PortalId:0
UserId:1
TabId:149
RawUrl:/
Referrer:https://xxxxxxxxx.nl/DesktopModules/admin/Dnn.PersonaBar/index.html?cdv=228
UserAgent:Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36
ExceptionHash:NKrsQQ9svYlQ47RT4hxhRIGHugw=
Message:Could not load type 'DotNetNuke.Services.FileSystem.FileController' from assembly 'DotNetNuke, Version=9.2.2.178, Culture=neutral, PublicKeyToken=null'.
StackTrace:
InnerMessage:Could not load type 'DotNetNuke.Services.FileSystem.FileController' from assembly 'DotNetNuke, Version=9.2.2.178, Culture=neutral, PublicKeyToken=null'.
InnerStackTrace:
at DotNetNuke.Modules.Xml.Components.Utils.CreateXmlReader(String xmlsrc, Int32 portalId, Boolean prohibitDtd) at DotNetNuke.Modules.Xml.Providers.XmlRenderingProvider.XslCompiledTransform.Provider.GetXslTransform(String xslsrc, Int32 portalId) at DotNetNuke.Modules.Xml.Providers.XmlRenderingProvider.XslCompiledTransform.Provider.Render(XmlReader reader, TextWriter output, Page page, ModuleInfo moduleConfiguration) at DotNetNuke.Modules.Xml.Components.XmlBaseController.Render(TextWriter output) at DotNetNuke.Modules.Xml.XmlModule.Page_Load(Object sender, EventArgs e)
Source:

FileName:
FileLineNumber:0
FileColumnNumber:0
Method:

Describe the bug

When building the module there are 23 warnings, mostly for deprecated API usages

To Reproduce

Steps to reproduce the behavior:

1. Clone repository
2. Build module
3. Notice the warnings

Expected behavior

Module should not use any deprecated API

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

May resolve #7 and #2

We need a pull request template to be consistent with other DNN Community repos

Please summarize your question in one sentence

An XML feed using https:// doesn't seem to display anything.

Give a more extended description

I'm trying to display an XML feed that is hosted on another site. The file is https secure. When I enter it into the settings of the module, the content doesn't display. Only files that are local to the DNN file system or non-https (HTTP) files will display content.

Steps to reproduce (if needed)

1. Edit Module Configuration
2. Data Source Typ: HTTP
3. Location: ( Enter The Address Of The Link ): Put in a hosted XML file that uses https://
4. The content won't display
5. Edit Module Configuration again
6. Enter a hosted XML file that is not HTTPS (http only)
7. You'll see that the non-secure HTTP file works. HTTPS doesn't work.

Other comments or remarks

DNN 9.3.1
DNN XML 6.0.5