Describe the bug

We use table qualifiers with our DNN installations so all tables are QUAL_table_name. I hadn't noticed before but this also passes to the stored procedures. Working on an upgrade of an old 9.1.1 to 9.4.4 and found when I upgrade to Links 7.0.1 it stops working throwing this error.

Error: Policies is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Could not find stored procedure 'dnnLinks_GetLinks'.

That's because the stored procedure name is really "OurQual_dnnLinks_GetLink"

Software Versions

• DNN: 9.1.1 & 9.3.2
• Module: 7.0.1 (works in 6.0.2 & 6.2.3)

To Reproduce

Steps to reproduce the behavior:

1. Install DNN with table qualifiers
2. Use Links 6.2.3 to make some links
3. Upgrade to Links 7.0.1
4. Load page with links
5. See error

Error log

Debug DLLs instaled

Error: Policies is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Could not find stored procedure 'dnnLinks_GetLinks'. ---> System.Data.SqlClient.SqlException: Could not find stored procedure 'dnnLinks_GetLinks'. at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction) at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose) at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady) at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData() at System.Data.SqlClient.SqlDataReader.get_MetaData() at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted) at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest) at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry) at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior, String method) at PetaPoco.Database.d__21.MoveNext() at System.Collections.Generic.List1..ctor(IEnumerable1 collection) at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source) at PetaPoco.Database.Fetch[T](String sql, Object[] args) at DotNetNuke.Modules.Links.Components.LinkController.GetLinks(Int32 moduleId) in D:\websites\dnn920\DesktopModules\DNN.Links\Components\LinkController.cs:line 238 at DotNetNuke.Modules.Links.Links.Page_Load(Object sender, EventArgs e) in D:\websites\dnn920\DesktopModules\DNN.Links\Links.ascx.cs:line 542 --- End of inner exception stack trace ---

Describe the bug

If setted to "Menu", the links module will only reflect per RoleID permissions

Software Versions

• DNN: v. 09.02.02 (178)
• Module: 7.0.1

To Reproduce

Steps to reproduce the behavior:

1. Add a Links module
2. Apply the Menu mode in Module Settings
3. Point the module to any page with custom per User permissions
4. Look at your Links module, is not reflecting those permissions

Expected behavior

User permissions to be reflected.

Hi,

I'm using Links version 6.2.3 / DNN 9.1.1 (on a test server ) .

I have some Links instances which cannot be changed from control type List to Dropdown .
When I look at the Setting Value in the database, it does change from L to D (and back) when I change the setting from the Admin tools in the module. But the display never changes to Dropdown. (I have other instances, which are stuck on Dropdown and can't be changed to List mode).

This problem applies to instances which I've created in older versions of the Links module. When I create a new instance , I can change its control type.

Anyone else seen this issue? Is there any way to fix it so I won't have to re-make all my dropdowns if I upgrade to 6.2.3 on our live site?

Thanks

Tom

I am using version 6.2.3. It appears that there is a bug in the settings for links to show in dropdown mode. No matter which radio button (yes or no) is selected for using individual permissions on links, the module gets stuck in the yes position. After that point, the "yes" command then gets stuck on, no matter which mode, list or dropdown, you try to use. You can click the "no" button and update, but there is no change in behavior. Even in the example below where "no" is selected, the behavior is as if "yes" is selected. The only way I have found to break this behavior is to make a complete copy of the module and reinsert it on the page. The module will revert back to list mode and the permissions behavior is as if "no" is selected. But, if you switch back to dropdown mode, it automatically turns on the individual permissions, even if I never touch those radio buttons.

Describe the bug

After installing the module, any page that uses it is blank in view mode and shows an error in edit mode.

Software Versions

• DNN: 09.02.01
• Module: 07.00.01

Error log

Message: Could not find stored procedure 'dnnLinks_GetLinks'.
StackTrace:
InnerMessage:Could not find stored procedure 'dnnLinks_GetLinks'.
InnerStackTrace: at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction) at System.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction) at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose) at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady) at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData() at System.Data.SqlClient.SqlDataReader.get_MetaData() at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted) at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest) at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry) at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior, String method) at System.Data.SqlClient.SqlCommand.ExecuteDbDataReader(CommandBehavior behavior) at System.Data.Common.DbCommand.ExecuteReader(CommandBehavior behavior) at Glimpse.Ado.AlternateType.GlimpseDbCommand.ExecuteDbDataReader(CommandBehavior behavior) at System.Data.Common.DbCommand.System.Data.IDbCommand.ExecuteReader() at PetaPoco.Database.d__21.MoveNext() at System.Collections.Generic.List1..ctor(IEnumerable1 collection) at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source) at PetaPoco.Database.Fetch[T](String sql, Object[] args) at DotNetNuke.Data.PetaPoco.PetaPocoDataContext.ExecuteQuery[T](CommandType type, String sql, Object[] args) at DotNetNuke.Modules.Links.Components.LinkController.GetLinks(Int32 moduleId) in D:\websites\dnn920\DesktopModules\DNN.Links\Components\LinkController.cs:line 238 at DotNetNuke.Modules.Links.Links.Page_Load(Object sender, EventArgs e) in D:\websites\dnn920\DesktopModules\DNN.Links\Links.ascx.cs:line 542

is there a way to sort links from a -z. also when importing links the permissions for each link is not set. I have to go through each link and set permissions . Is there a way to add this permission in the xml file ?

I need to show a links module to all users, but one of the links in it should only show when the user is unauthenticated.

The Links module permissions were set to show to All Users. Under 'Links Settings', I set the Use Permissions value to Yes.

In the Edit Links screen, the Unauthenticated Users role was selected for my link. No other roles were selected. However, the link shows to all users, whether they are logged in or not.

WCAG 2.0 analyzer wants a unique ID attribute for each item in the list.
each list item begins <li id="itemLi" class="linkItem"...
perhaps could be <li id="itemLi_1" class... ??

Software Versions

• DNN: 9.x
• Module: 7.00.01

To Reproduce

Steps to reproduce the behavior:

1. add several link items to a links module
2. inspect element on any list item. They're each id="itemLi"

Expected behavior

when generating the view, for each item output id="itemLI_"+itemnumber?

There should be some checkbox kind of thing asking to keep the particular link enabled or disabled.
Or is there a way to make url field optional because as per database url field is allowing nulls but somewhere validation is applied not to keep that url field blank.

Describe the bug

A clear and concise description of what the bug is.

Software Versions

• DNN: 09.03.02 (but not dnn related)
• Module: 07.00.01

To Reproduce

Steps to reproduce the behavior:

1. Install links module
2. Try to insert module on page
3. Notice sql errors

Error: Links is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: C:\inetpub\dnn\DesktopModules\Links\Links.ascx.vb(557): error BC30560: 'LinkController' is ambiguous in the namespace 'DotNetNuke.Modules.Links'. ---> System.Web.HttpCompileException: C:\inetpub\dnn\DesktopModules\Links\Links.ascx.vb(557): error BC30560: 'LinkController' is ambiguous in the namespace 'DotNetNuke.Modules.Links'. at System.Web.Compilation.BuildManager.CompileWebFile(VirtualPath virtualPath) at System.Web.Compilation.BuildManager.GetVPathBuildResultInternal(VirtualPath virtualPath, Boolean noBuild, Boolean allowCrossApp, Boolean allowBuildInPrecompile, Boolean throwIfNotFound, Boolean ensureIsUpToDate) at System.Web.Compilation.BuildManager.GetVPathBuildResultWithNoAssert(HttpContext context, VirtualPath virtualPath, Boolean noBuild, Boolean allowCrossApp, Boolean allowBuildInPrecompile, Boolean throwIfNotFound, Boolean ensureIsUpToDate) at System.Web.UI.TemplateControl.LoadControl(VirtualPath virtualPath) at DotNetNuke.UI.ControlUtilities.LoadControl[T](TemplateControl containerControl, String ControlSrc) at DotNetNuke.UI.Modules.WebFormsModuleControlFactory.CreateModuleControl(TemplateControl containerControl, ModuleInfo moduleConfiguration) at DotNetNuke.UI.Modules.ModuleControlFactory.LoadModuleControl(TemplateControl containerControl, ModuleInfo moduleConfiguration) at DotNetNuke.UI.Modules.ModuleHost.LoadModuleControl() --- End of inner exception stack trace ---

Describe the bug

The Telerik Dependency Report reports a dependency to DotNetNuke.Modules.Links.dll

Software Versions

• DNN: 09.08.00
• Module: 07.00.01

Expected behavior

Telerik Dependencies should be removed for security reasons.

Is it possible to have an icon after a link?
For example : I have placed a links module onto a page. Now I am adding a link and I have attached pdf to that link, so I want the small pdf icon to appear after the link. similarly, if I add next link and attach an excel to that link, an excel icon should appear after the link.

Adding Links module v8.0.1 to a pg on a dnn 9.11 site,
visit module settings.
under links settings, attempt to change mode from Link to Folder, get:
Error: Links is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Object reference not set to an instance of an object. ---> System.NullReferenceException: Object reference not set to an instance of an object. at DotNetNuke.Modules.Links.Settings.LoadContentData(String pContentType) at DotNetNuke.Modules.Links.Settings.optLinkModuleType_SelectedIndexChanged(Object sender, EventArgs e) --- End of inner exception stack trace ---
IF I then change the mode to Link or Menu, settings page refreshes and is fine; shows me page menu dropdown.
If I then change mode to Folder i get the same error again.
IF I then change to menu and save the module, then go back into settings, I can change the mode to folder, and after refreshing, a folder list appears to make a selection.

Describe the bug

After upgrading to DNN 9.4.4, I am seeing this error in the admin logs. It appears to be caused by the module indexer. I have verified that 'SC_dnnLinks_GetLinks' exists as a stored procedure.

Software Versions

• DNN: 09.04.04
• Module: 07.00.01

To Reproduce

It happens when the module indexer runs.

Expected behavior

No error.

Error log

AbsoluteURL:
DefaultDataProvider:DotNetNuke.Data.SqlDataProvider, DotNetNuke
ExceptionGUID:744c617a-63a9-4b04-8d7d-a936320b77eb
AssemblyVersion:
PortalId:-1
UserId:-1
TabId:-1
RawUrl:
Referrer:
UserAgent:
ExceptionHash:EywjChDU6EGiOKJaJrxZvw9I2J4=
Message:Could not find stored procedure 'dnnLinks_GetLinks'.
StackTrace:
at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction) at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose) at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady) at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData() at System.Data.SqlClient.SqlDataReader.get_MetaData() at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted) at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest) at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry)
at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method)
at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior, String method)
at PetaPoco.Database.d__1491.MoveNext() at System.Collections.Generic.List1..ctor(IEnumerable1 collection) at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source)
at DotNetNuke.Modules.Links.Components.LinkController.GetLinks(Int32 moduleId)
at DotNetNuke.Modules.Links.Components.FeatureController.GetModifiedSearchDocuments(ModuleInfo moduleInfo, DateTime beginDateUtc)
at DotNetNuke.Services.Search.ModuleIndexer.IndexSearchDocuments(Int32 portalId, ScheduleHistoryItem schedule, DateTime startDateLocal, Action`1 indexer)

InnerMessage:
InnerStackTrace:

Source:.Net SqlClient Data Provider
FileName:
FileLineNumber:0
FileColumnNumber:0
Method:

I didn't upgrade my Links module from 4.0.1 to 6.2.2 because (under DNN 7) it would cause the dropdown lists to break and not function as links (I posted this in another issue, but nobody responded).

Now, I've upgraded DNN to 9.1.0 and (still using Links 4.0.1) notice that I'm unable to edit items in Links module dropdown lists. It's possible to edit the first item in the lists, but when I select any other item and hit the Edit button, there is a blink, but it never gets to the Edit page.

So, on a test server (also running DNN 9.1.0), I've tried upgrading the Links module to 6.02.03, to see if it might work properly now. Nope. It's now giving critical errors for all the existing Linsk dropdown menus on the website. I will post an error below inside this message.

Does anyone know what I should do? How can I get the Links Module to work properly with DNN 9?

Also, if not here, where can I get help/support about the Links module?

Thanks

Tom

Here is the error:

ModuleId:510

ModuleDefId:119

FriendlyName:Links

ModuleControlSource:DesktopModules/Links/Links.ascx

AbsoluteURL:/Default.aspx

DefaultDataProvider:DotNetNuke.Data.SqlDataProvider, DotNetNuke

ExceptionGUID:802fd5e7-08d4-4fef-81ff-ddc2a81749b0

AssemblyVersion:9.1.0

PortalId:0

UserId:1

TabId:40

RawUrl:/Home.aspx

Referrer:

UserAgent:Mozilla/5.0 (Windows NT 10.0; rv:54.0) Gecko/20100101 Firefox/54.0

ExceptionHash:ASYzE04S6nZ+vrd4bNlSA2+bJiI=

Message:D:\Inetpub\wwwroot\SCCInternet_804_617\DesktopModules\Links\Links.ascx.vb(557): error BC30560: 'LinkController' is ambiguous in the namespace 'DotNetNuke.Modules.Links'.

StackTrace:

InnerMessage:D:\Inetpub\wwwroot\SCCInternet_804_617\DesktopModules\Links\Links.ascx.vb(557): error BC30560: 'LinkController' is ambiguous in the namespace 'DotNetNuke.Modules.Links'.

InnerStackTrace:

at System.Web.Compilation.BuildManager.PostProcessFoundBuildResult(BuildResult result, Boolean keyFromVPP, VirtualPath virtualPath) at System.Web.Compilation.BuildManager.GetBuildResultFromCacheInternal(String cacheKey, Boolean keyFromVPP, VirtualPath virtualPath, Int64 hashCode, Boolean ensureIsUpToDate) at System.Web.Compilation.BuildManager.GetVPathBuildResultFromCacheInternal(VirtualPath virtualPath, Boolean ensureIsUpToDate) at System.Web.Compilation.BuildManager.GetVPathBuildResultInternal(VirtualPath virtualPath, Boolean noBuild, Boolean allowCrossApp, Boolean allowBuildInPrecompile, Boolean throwIfNotFound, Boolean ensureIsUpToDate) at System.Web.Compilation.BuildManager.GetVPathBuildResultWithNoAssert(HttpContext context, VirtualPath virtualPath, Boolean noBuild, Boolean allowCrossApp, Boolean allowBuildInPrecompile, Boolean throwIfNotFound, Boolean ensureIsUpToDate) at System.Web.UI.TemplateControl.LoadControl(VirtualPath virtualPath) at DotNetNuke.UI.ControlUtilities.LoadControl[T](TemplateControl containerControl, String ControlSrc) at DotNetNuke.UI.Modules.WebFormsModuleControlFactory.CreateModuleControl(TemplateControl containerControl, ModuleInfo moduleConfiguration) at DotNetNuke.UI.Modules.ModuleControlFactory.LoadModuleControl(TemplateControl containerControl, ModuleInfo moduleConfiguration) at DotNetNuke.UI.Modules.ModuleHost.LoadModuleControl()

Source:

FileName:

FileLineNumber:0

FileColumnNumber:0

Hi - I've been keeping on using Links 4.0.1 on our site, since it was working directly from selecting items in the select box, without the "Go" link. I'm running DNN 9.1.1. (I've worked with Links 6.2.3 on a test server and worked around the "Go" link, but on production site, was keeping version 4.0.1

On our test server, I was trying a trial of DNN Sharp My Tokens. When I would install MyTokens, it would break Links 4.0.1 (showed error in admin mode, and didn't show the Links module on the page). When I reinstall (repair) Links 4.0.1, it works, but now, it includes the "Go" link. I never saw the "Go" link in version 4.0.1 before (only in 6.2.3). Any idea what's going on?

I tried this a couple times on test server, with the same behavior. And it stays the same, even when I uninstall the MyTokens Extension.

None of this is a real problem, I can work around it - but just curious and wanted to let you know about it.

Thanks

Tom

Describe the bug

After installing latest version, site crashed with the following error:
[HttpException (0x80004005): The files '/App_Code/csharp/file.cs' and '/App_Code/Links/DataProvider.vb' use a different language, which is not allowed since they need to be compiled together.]

The issue was that the installer removed the following entry from the web.config file:

      <codeSubDirectories>
	      <add directoryName="csharp"/>
	      <add directoryName="Links"/>
      </codeSubDirectories>

Adding the entry back resolves the issue.

Software Versions

• DNN: 09.09.01
• Module: 08.00.00

To Reproduce

Steps to reproduce the behavior:

1. Assuming there is a "" entry in the web.config
2. Install the module
3. The entry in the web.config file will have been removed

Expected behavior

Don't remove the "" entry

Error log

`[HttpException (0x80004005): The files '/App_Code/csharp/file.cs' and '/App_Code/Links/DataProvider.vb' use a different language, which is not allowed since they need to be compiled together.]

Describe the bug

After upgrading to DNN 9.10.2, while trying to add or edit a link, when you change the "Link Type" option it to "File" it causes a blink, but "File Location", "File Name" and "Upload File" do not appear. Upgrading Links module from 7.0.1 to 8.0.0 did not change this behavior.

Software Versions

• DNN: 9.10.2
• Module: 8.0.0

To Reproduce

Steps to reproduce the behavior:

1. Click "Add Link"
2. Change "Link Type" to "File"
3. There is a blink.
4. "File Location", "File Name" and "Upload File" do not appear.

Expected behavior

Expected "File Location", "File Name" and "Upload File" to appear so a link to a file could be created or altered.

Screenshots

Error log

There are no errors in the Admin Log

Additional context

-Existing links to files are still clickable and open their target files.
-Tried with a Bootstrap 4 theme and a Bootstrap 5 theme. The behavior was identical.

Please summarize your question in one sentence

Looking for documentation on this module.

Give a more extended description

When adding a link there is a message "This Module is configured to show dynamic Data. Please use Modulesettings to change." what does this mean? Also, there is a setting called Get content: What is this used for?

See screenshot below.

Steps to reproduce (if needed)

Other comments or remarks

With previous versions of the Links module it was possible to create links to local files such as PDF documents or Excel spreadsheets. We use this functionality with our internal Intranet site. Yes, we could store our documents inside of the site itself and link to them that way, but we have a rather large repository of files on our file server and are not really interested in importing those into the site and managing them there.

With the new version, file:/// requests no longer seem to work. I've tried using the following variations:

file:///g:\folder\file.pdf
file:///g:/folder/file.pdf

Using a backslash character results in an error. Using the forward slash is accepted but simply doesn't work when the link is clicked.

Software Versions

• DNN: 09.03.02
• Module: 07.00.01

Please summarize your question in one sentence

When choosing link type of file I get "You don't have permission to see the files on this site" I'm an admin.

Give a more extended description

I'm in the process of upgrading dnn to version 9.10.6. I've installed the latest version of the links module. This is not specific to the links module, where ever I can choose a link type of file it occurs.

Steps to reproduce (if needed)

Other comments or remarks

Also, I'm unsure of why the module is saying that it's configured to use dynamic content. What is that and how do I change that?

I also don't understand why i'm seeing folder and roles for selection.

I am trying to add a link to a file, but uploading the file from the Links module (as I'm adding), but I get an error

So I am trying to add a link via the Links module (version 7.0.1, DNN version 9.3.2 and after I select the local file to upload then click the "upload file" button I receive an error. I don't know if this is a Links module issue, or a DB issue, or a config issue.

1. Select "edit mode" on site
2. Click "Add Link" on module
3. Select "File" for "Link Type"
4. Click "Upload New File"
5. Click "Choose File"
6. Select file from local drive, click OK, returns to edit link page
7. Click "Upload Selected File"
8. Message appears "A critical error has occurred. Please check the Event Viewer for further details."
9. Check log and find these details below

Message:startIndex cannot be larger than length of string. Parameter name: startIndex
StackTrace:
InnerMessage:startIndex cannot be larger than length of string. Parameter name: startIndex
InnerStackTrace:
at System.String.Substring(Int32 startIndex, Int32 length) at DotNetNuke.Common.Globals.GetSubFolderPath(String strFileNamePath, Int32 portalId) at DotNetNuke.UI.UserControls.UrlControl.cmdSave_Click(Object sender, EventArgs e) at System.Web.UI.WebControls.LinkButton.OnClick(EventArgs e) at System.Web.UI.WebControls.LinkButton.RaisePostBackEvent(String eventArgument) at System.Web.UI.WebControls.LinkButton.System.Web.UI.IPostBackEventHandler.RaisePostBackEvent(String eventArgument) at System.Web.UI.Page.RaisePostBackEvent(IPostBackEventHandler sourceControl, String eventArgument) at System.Web.UI.Page.RaisePostBackEvent(NameValueCollection postData) at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)

Describe the bug

When editing a link, the delete option is not working. When you click on the delete link, nothing happens.

Software Versions

• DNN: 09.03.02
• Module: 07.00.01

To Reproduce

Steps to reproduce the behavior:

1. Go to Link module with a couple of links already added
2. Click on the pencil to the left of the link
3. Scroll down to delete option and click on the word delete.
4. No error but nothing happens either.

Try to install this module in Windows Azure environment (EE 7.3.3.117), but a pop-up displays with the warning: This package is not verified to be compatible with Azure SQL Database.

If you ignore the warning and continue the installation, it will fail.

I have thousands of these errors, and i clear the logs regularly because they build up quickly on a very busy site. The module's used multiple times on 92 pages of the site. We use the links module in folder mode to display pdf documents. The problem's been happening since v9.10.2 and continues in v9.11. Links module is 8.0.0. the error is:
01/22/2023 15:01:15 Module Load Exception
Will County Illinois
ModuleId 1817 ModuleDefId 140 FriendlyName SHNH Soft Goods Bid ModuleContr
ModuleId:1817

ModuleDefId:140

FriendlyName:SHNH Soft Goods Bid

ModuleControlSource:DesktopModules/Links/Links.ascx

AbsoluteURL:/Default.aspx

DefaultDataProvider:DotNetNuke.Data.SqlDataProvider, DotNetNuke

ExceptionGUID:7e0e9984-bde1-4310-9f86-8026722f71ef

AssemblyVersion:9.11.0

PortalId:0

UserId:-1

TabId:481

RawUrl:/County-Offices/Administration/Purchasing/2011Awarded-Bids/FileId/2353

Referrer:https://www.google.com/

UserAgent:Mozilla/5.0 (Linux; Android 12; SM-S908U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Mobile Safari/537.36

ExceptionHash:XdTznXRMOTdaPF6R59pDGe6tyOc=

Message:Server cannot clear headers after HTTP headers have been sent.

StackTrace:

InnerMessage:Server cannot clear headers after HTTP headers have been sent.

InnerStackTrace:

at System.Web.HttpResponse.ClearHeaders()
at DotNetNuke.Services.FileSystem.FileManager.WriteFileToHttpContext(IFileInfo file, ContentDisposition contentDisposition)
at DotNetNuke.Services.FileSystem.FileManager.WriteFileToResponse(IFileInfo file, ContentDisposition contentDisposition)
at DotNetNuke.Modules.Links.Links.Page_Load(Object sender, EventArgs e)
Source:

FileName:

FileLineNumber:0

FileColumnNumber:0

Method:

Server Name: CS01025920

Referrer sometimes is a search page, sometimes is on the site itself.

Is your feature request related to a problem?

No problem or issues.

Describe the solution you'd like

When using the Links module to list pages on your website, it would be nice if the current page being viewed (which is also listed as a link) can have a class named "Active" or something similar so that it's highlighted or bolded in the links listing.

For e.g.:
Home
This
That
Other

I'm on "This" page.

i want to display the number of times a file has been downloaded from my dnn website on the page where the link has been clicked.can that be added as an option in the link settings?

Where, exactly, can you change this text, if at all? The only place I can find is in EditLinks.ascx, which is suboptimal. There's no place in the module settings that I can find that allows you to change (or add) any sort of text to the module.

Our use case is that we'd like to replace that line of text with some instructions ("PDFs only", that sort of thing).

I have this working on one of my DNN installations as version 4.0.1. Later versions don't work for me in DNN 9. I wanted to install Links 4.0.1 to my other DNN site,. Itried to create a package from the working one, but it didnt work when I tried to install it. So I'd like to find a version of Links 4.0.1 to install.

Tom

Describe the bug

When trying to edit a link, the url on the edit button has extra characters that prevent it from working properly

Software Versions

• DNN: 09.02.00
• Module: 07.00.00

To Reproduce

Steps to reproduce the behavior:

1. Go to a page that has links
2. Click on the edit icon next to a link
3. See error: A potentially dangerous Request.Path value was detected from the client (<).

Expected behavior

The link editor should show up

Screenshots

Error log

URL: http://dnn920.localtest.me/DesktopModules/Links/%3C%25%20EditURL(%22ItemID%22,Eval(%22ItemID%22))%20%25%3E

Browser:

[HttpException (0x80004005): A potentially dangerous Request.Path value was detected from the client (<).]
System.Web.HttpRequest.ValidateInputIfRequiredByConfig() +9940664
System.Web.PipelineStepManager.ValidateHelper(HttpContext context) +53

I would like to check with people following this repository about how many people use the Friends mode.

Removing support for friends mode would make the module easier to maintain and would allow for quick removal of the Telerik Dependencies. The Friends mode is the main usage of Telerik in the module.

When you have a Links module on the page and attempt to either:

1. Drag the module to another pane
2. Add a new module to the page

The content of the Links module disappears. It returns after refreshing the page however.

In a link module I wanted to export the links to import them into another link module. Unfortunately, the links were not imported.

Describe the bug

After the conversion of DNN EVOQ to DNN Platform 9.2.2. We are experiencing problems with the updated DNN Link module version 7.01. If you enter a new link in a converted link module, it will only visible when be logged in and when logged out.

Software Versions

• DNN: 09..02.02
• Link Module: 07.00.01

To Reproduce

With a converted link module.
Add a new link in the converted link module an don't choose any roles.
When logged in the link is visible. When logged out, the link is not visible.
The module setting 'Use Permissions' is 'Yes'.
If you want the change it to 'No' you cannot save the setting.
A look in the table ModuleSettings setting 'use permissions' says 'false'.
The setting will not change, even if I do the reverse nothing happens!
In the settings from the table Link i see the value GrantRoles ;0; for the not visible link and ;-2; for the visible link.

New link module
If you place a new module on a page, the module will work as expected!
The module setting 'Use Permissions' is 'No' (not using any roles, just everyone).

Workaround

When you add a new link in a converted Link module you have to change GrantRoles settings for the link in ;-2; otherwise the new link will not shown when logged out!

Expected behavior

After the conversion from EVOQ to DNN Platform you expect when you add a new link this is shown., even if you are logged out!

Strange logic?

The logic I don't understand? In the Link module you can set 'No' use permissions (if you could save the setting). When you enter a new link, you can still ticked a role per link?
The possibility to choose a role should not be shown in my opinion!

Describe the bug

After updating to DNN 9.9.1, when the user selects "Add Link" and then selects "Link type: File (A File on Your Site)" a message appears: "You don't have permission to see the files on this site", and user is unable to browse/select a File to link.

Software Versions

• DNN: 9.9.1 (bug did not occur before upgrading DNN - worked correctly in DNN 9.6.1)
• Module: Links 8.0.0 (also occurred in 7.0.1 (only with DNN 9.9.1))

To Reproduce

Steps to reproduce the behavior:

1. Log in as admin to DNN page
2. In a Links module, select "Add Link"
3. Select "File" in the "Link Type:" section
4. A message "You don't have permission to see the files on this site."

Expected behavior

"File Location" and "File Name" Dropdowns should open to allow selecting a file from the webserver

Screenshots

Error log

No error log

Additional context

On DNN 9.11 we are using module Links 8.0.0 and we authorised a user. The user cannot link a file and get an error 'You are not authorized to upload files!' We got the same error in the module Documents! Something wrong with the URL-controller?

Describe the bug

If setted to "Menu", the links module will display also trashed tabs, disabled tabs and not visible tabs.

Software Versions

• DNN: v. 09.02.02 (178)
• Module: 7.0.1

To Reproduce

Steps to reproduce the behavior:

1. Add a Links module
2. Apply the Menu mode in Module Settings
3. Point the module to any page with some sub pages. Save
4. Move any of the sub pages to trash bin.
5. Look at your Links module, the link to the trashed page still there

Expected behavior

Trashed pages should not by listed

Additional context

The same behaviour happens with disabled pages and not visible pages

Does v6.3.2 support DNN 8.x and 9.x?

I installed links 6.2.3 on Evoq Content 9.1.1 and it was working perfectly fine. But we had to upgrade Evoq content from 9.1.1 to 9.3.0. In 9.3.0, the links module 6.2.3 is completely breaking. So I upgraded links module to 7.0.1 version and can see some of the links module partially breaking. When I click the pencil icon next to links instead of opening the section where we enter title, provide url etc, it is showing erro 'object reference not set to an instance of an object'.

• Evoq Content: 9.3.0
• Module: Links module 6.2.3 and 7.0.1

I have many instances of Links that I created years ago using Links version 4.
I'm upgrading DNN to 9.2.2 and then 9.3.2, and need to upgrade Links in order to do so. When I upgrade Links to 7.0.1, it breaks the Links lists . For each Links instance, I get two errors on the page which look like:

Error: Quick Find is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Object reference not set to an instance of an object. ---> System.NullReferenceException: Object reference not set to an instance of an object. at DotNetNuke.Modules.Links.Links.Page_Load(Object sender, EventArgs e) --- End of inner exception stack trace ---

In Admin logs, I get:

**ModuleId:**510
**ModuleDefId:**119
**FriendlyName:**Links
**ModuleControlSource:**DesktopModules/Links/Links.ascx
AbsoluteURL:/Default.aspx
**DefaultDataProvider:**DotNetNuke.Data.SqlDataProvider, DotNetNuke
**ExceptionGUID:**7e201717-f57a-4873-b9b3-42fc4f47c2de
**AssemblyVersion:**9.1.1
**PortalId:**0
**UserId:**389
**TabId:**40
RawUrl:/Home.aspx
**Referrer:**http://sccinternettest/Home.aspx
**UserAgent:**Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36
**ExceptionHash:**gLYPsBPv57CkbMoI7QRubZb1sGk=
**Message:**Object reference not set to an instance of an object.
StackTrace:
**InnerMessage:**Object reference not set to an instance of an object.
InnerStackTrace:
at DotNetNuke.Modules.Links.Links.Page_Load(Object sender, EventArgs e)
Source:
FileName:
**FileLineNumber:**0
**FileColumnNumber:**0
Method:
Server Name: SCTAS35

I am able to create new instances of Links dropdowns, but it would be great if I could get the existing ones to work (and didn't have to re-build them all) . I can tell that the data is still there. Any suggestions for fixing the error?

Thanks

Tom

Enterprise mode is a feature that opens defined web sites in IE 11, even when a link to that site is clicked in Edge. This is important for sites that contain Java Applets or other Plugins not supported by Edge. See https://technet.microsoft.com/en-us/itpro/microsoft-edge/emie-to-improve-compatibility for more information.
When using DNN's LinkClick.aspx (e.g. to count the clicks or track the users), the site is opening in Edge.

Describe the bug

Need to target for the older dnn version supported (7.2.0) to prevent using APIs that do not exist in 7.2.0

To Reproduce

Steps to reproduce the behavior:

1. Clone repository on a vanilla Visual Studio without myget configured
2. Not it is impossible to build the project

Expected behavior

Should be able to build without errors on first try

Is your feature request related to a problem?

With the module in 'link' mode, if the main setting UsePermissions is setted to false, the EditLink page should not display the user role table, confusing users.

Describe the solution you'd like

If UsePermissions is false, then the GrantRoles table should not be visible.
This code in the Page_Load of EditLinks.ascx.cs will make it

if (System.Convert.ToBoolean(Settings[Dnn.Links.SettingName.UsePermissions]) == false) {
  plGrantRoles.Visible = false;
  cblGrantRoles.Visible = false;
}

PopupTrigger code(?) Appears within generated link code

Is this proper functioning of the generated menu code?

When the setting is set to MENU, the generated LI list of menu items includes a class of "Normal<%PopupTrigger%>"

as in example:

<a href="http://domainname.com/ParentPage/Page-Name-Here" id="dnn_ctr459_Links_lstLinks_linkHyp_1" class="Normal<%#PopupTrigger%>" alt="alt text here." target="_self">
                    Page Name Here
                </a>

Software Versions

• DNN: 09.02.02
• Module: 07.00.01

To Reproduce

Steps to reproduce the behavior:

1. Go to the Links module instance Module Settings
2. Within the Link Settings tab, set the module mode to MENU and select a parent page
3. Scroll down to '....'
4. view the generated source code of the menu list to see the class="Normal<%#PopupTrigger%>"
   content

Expected behavior

Unsure... this could be intended behavior that I am unaware of, but wanted to report for review.

Hi, I used the DNN Links module to create dropdowns on our websites, and when I upgraded the Links module, the dropdowns don't work properly, in two ways.

1. The Use Permissions setting doesn't seem to work, so all the items in each list need to be explicitly set or they don't show.
2. There is no auto post back function, which means that when an item is selected in the dropdown list, the page doesn't go to the link. There is "GO" link next to the dropdown which you need to click after making the selection.

Number 2 is the real problem. Why was the post back function taken out of the Links module? Is there an easy way to restore this functionality, or if not, should I go back to using the old version of the Links module? It will be a ton of work to recode all my dropdowns if I can't use Links for this anymore.

Here's an example of the proper function of these Links/ Dropdowns (three dropdowns on the top right side of the page):

http://www.co.santa-cruz.ca.us/

Thanks!

Tom

Installing v7.0.1 within Evoq 8.5.0. Running .NET 4.8.0.

During the installation process, error reports:

Describe the bug

Installing into an Evoq Content 8.5 DNN instance where the older DNN Links module has, over time, gone from older versions Links 6.0.2 to newer DNN_Links 6.2.3 the install/upgrade of DNN_Links 7.0.1 failed with an error on install (shown below).

Thing is, since there's a history of older files and upgrades, I'm not sure whether this issue encountered is specific to this instance, or an issue with the upgrade file... I'll try to test on another DNN instance to help test situations

Software Versions

• DNN Evoq Content: 08.05.00
• Module DNN_Links: 07.00.01

To Reproduce

Steps to reproduce the behavior:
Upgrading with DNN_Links installer 7.0.1
Received the following Error in install steps: