Support for UTF-8 charset about gulp-sass HOT 19 CLOSED

Any idea if this is a problem with node-sass?

from gulp-sass.

I'm not sure, because I don't know how to test UTF-8 comments in node-sass. I'm a node newbie.

What I can provide more in detail is that the gulp-sass can handle Chinese comments in the partial file correctly by using @import command.

from gulp-sass.

Node-sass supports @charset "UTF-8";

from gulp-sass.

@houhr If you could provide a gist or something with a sample of the files that are not working, I'll see if I can figure out how to make them work.

from gulp-sass.

We use @charset "UTF-8"; with gulp-sass and it compiles for our project. You can test it with the node-sass command instead of the sass command.

from gulp-sass.

@dlmanning You can use this gist to conduct a test. BTW, by considering other problems of gulp-sass, such as cannot use variables in the comments, we have replace it with gulp-ruby-sass.

from gulp-sass.

@apriendeau I've tried put @charset "UTF-8"; at the SCSS file's beginning, but it still didn't work. Could you show me how you did it?

from gulp-sass.

@houhr I trimmed the example down a lot. Our style.scss has a lot more imports and gulp has uglify, concat and some other tasks but this should be enough to do what you need. It is here in this gist.

from gulp-sass.

So I rendered this with node-sass.

/*!
 *  hi there 中文注释 #{$a}
 */

and this with gulp-sass

/*!
 *  hi there -��� #{$a}
 */

so it does look like a bug here or possibly gulp because I believe its happening when the file converts to a string.
https://github.com/dlmanning/gulp-sass/blob/master/index.js#L22

from gulp-sass.

@apriendeau It seems we used @charset "UTF-8"; in the same way, and it indeed doesn't work for Chinese comments. Thank you all the same : )

from gulp-sass.

Least we narrowed it down. 👍

from gulp-sass.

Thanks both of you.

This is all gulp-sass does to convert the file buffer to a string:
opts.data = file.contents.toString();

The default encoding format for Buffer.toString() is utf8, so I'm not immediately sure what's going on. Any suggestions?

from gulp-sass.

I tried explicitly setting 'UTF-8' and that didn't work. So I think it might be coming from file.contents, itself. So it very well could be a bug in gulp itself.

from gulp-sass.

Alright, I probably need to write some test cases for vinyl-fs and see if I can pin down what's happening.

from gulp-sass.

This isn't a bug in gulp-sass, but in node-sass. The "render" method of the libsass-binding processes either a scss-file (that happens if you compile a scss file directly with the bin/node-sass cli script) or a scss-string (that's the default case with gulp-sass). In the latter case the success callback function receives the compiled scss code with broken unicode.

from gulp-sass.

I have the same issue when use content
&:before{ content: "\201C"; } &:after{ content: "\201D" }
CSS begin with @charset "UTF-8"; 😢

from gulp-sass.

This has been resolved in 2.x. Please try it and report back. If we don't hear back, we'll assume it's been resolved and close this issue.

npm install dlmanning/gulp-sass#2.x

from gulp-sass.

As it's been a month, I'm closing this.

from gulp-sass.

Hi, i am using "gulp-sass": "^2.3.2", and i still have the issue.

"\f26e" text is still badly transpiled :(

from gulp-sass.