The indicatif-log-bridge from djugei

Is this compatible with flex_logger?

Is this compatible with flexi_logger?

I try to use it like this:

    let _logger = Logger::try_with_str("debug")
        .unwrap()
        .format(opt_format)
        .log_to_file(FileSpec::default().directory("./log"))
        .duplicate_to_stderr(Duplicate::Error)
        .write_mode(WriteMode::BufferAndFlush)
        .start()
        .unwrap();

    let multi_progress = MultiProgress::new();

    LogWrapper::new(multi_progress.clone(), _logger)
        .try_init()
        .unwrap();

I'm getting the following error:

error[E0277]: the trait bound `LoggerHandle: log::Log` is not satisfied
   --> src\main.rs:127:5
    |
127 |     LogWrapper::new(multi_progress.clone(), _logger)
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `log::Log` is not implemented for `LoggerHandle`
    |
    = help: the following other types implement trait `log::Log`:
              &T
              Arc<T>
              Box<T>
              LogWrapper<L>
note: required by a bound in `LogWrapper`
   --> C:\Users\User\.cargo\registry\src\index.crates.io-6f17d22bba15001f\indicatif-log-bridge-0.2.2\src\lib.rs:43:26
    |
43  | pub struct LogWrapper<L: Log> {
    |                          ^^^ required by this bound in `LogWrapper`

I also tried to separate out the flexi_logger call of .start() so that I had a Logger rather than LoggerHandle, but that did not seem to help. Any guidance is greatly appreciated!

Unncessary suspend for disabled log

suspend is unconditionally in log even if that log is not enabled. This may cause unnecessary twinkling of the progress bar. The behavior can be seen in the attached video.

I am using bindgen which will issue many debug logs and warn logs under the hood, but I delibrately filter out most of the bindgen logs. Therefore, it's not possible for me to adjust the number of log macros I call to fix my issue.

indicatif-log-bridge/src/lib.rs

Lines 87 to 89 in 51dc006

 fn log(&self, record: &log::Record) { 

 self.bar.suspend(|| self.log.log(record)) 

 }

Can we modify it to the following? I have verified this modification fixes my issue. Thanks.

    fn log(&self, record: &log::Record) {
        if self.enabled(record.metadata()) {
            self.bar.suspend(|| self.log.log(record))
        } else {
            self.log.log(record)
        }
    }

This can be easily unit tested. Thanks!

indicatif-log-bridge-issue.mp4

djugei / indicatif-log-bridge Goto Github PK

indicatif-log-bridge's People

Contributors

Stargazers

Watchers

indicatif-log-bridge's Issues

Is this compatible with flex_logger?

Unncessary suspend for disabled log

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	fn log(&self, record: &log::Record) {
	self.bar.suspend(\|\| self.log.log(record))
	}