The following change silences the warning about "Sha.test" being a bad module name, and allows the linker to find the SHA libraries in the current directory.

-OCAML_TEST_INC = -I ocamlfind query oUnit
+OCAML_TEST_INC = -I ocamlfind query oUnit -I . -w -24

Issue description and patches submitted by Goswin von Brederlow:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=663520#20

This patch allows building on architectures without native code compilers. It fixes Debian bug #616176.

http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocaml-sha.git;a=blob_plain;f=debian/patches/0004-add-all-byte-and-install-byte-targets.patch;hb=HEAD

I apply this patch in the Debian packaging of ocaml-sha; please consider it for the upstream version:

http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocaml-sha.git;a=blob_plain;f=debian/patches/0001-install-mli-files.patch;hb=HEAD

Hi, the library is advertised as unmaintained, and PRs/issues are old. Would you mind if someone took over the project (keeping it in the same spirit, of course)? It looks pretty robust, but small improvements are always useful (for instance, I think some functions could release the GC lock). I volunteer if no one else wants…

I'm replacing my pure OCaml versions of the sha functions in CamlPDF, for speed, and I'd like to try ocaml-sha. However, since we distribute statically linked binaries, I can't do that. Would you consider adding the standard linking exception to your LGPL license?

This is the exception several OCaml projects use, for example X. Leroy's "CamlZip", which we already use. This is the modifying text, although you replace "INRIA" obviously:

As a special exception to the GNU Lesser General Public License, you
may link, statically or dynamically, a "work that uses the Library"
with a publicly distributed version of the Library to produce an
executable file containing portions of the Library, and distribute
that executable file under terms of your choice, without any of the
additional requirements listed in clause 6 of the GNU Lesser General
Public License.  By "a publicly distributed version of the Library",
we mean either the unmodified Library as distributed by INRIA, or a
modified version of the Library that is distributed under the
conditions defined in clause 3 of the GNU Lesser General Public
License.  This exception does not however invalidate any other reasons
why the executable file might be covered by the GNU Lesser General
Public License.

Whatever you decide, could you add a LICENSE file to the repository, to make it clear what license covers all the files?

I apply this patch in the Debian packaging of ocaml-sha; please consider it for the upstream version.

http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocaml-sha.git;a=blob_plain;f=debian/patches/0003-use-internal-ccopts-variable.patch;hb=HEAD

The computation is potentially costly, and since it's in C it should be parallelizable. I looked and it doesn't seem to be the case right now.

Would it be possible to make a new OPAM release with the OS X build fix? The current OPAM version does not build in OS X. Thanks!

There's no test for Sha1.to_bin; when I use it on a x86_64 machine, the data comes out with every group of four bytes in the opposite of the expected order

I apply this patch in the Debian packaging of ocaml-sha; please consider it for the upstream version. It fixes Debian bug #518038 (FTBFS on MIPS).

http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocaml-sha.git;a=blob_plain;f=debian/patches/0002-compile-C-files-with-fPIC.patch;hb=HEAD

With dune 2.0 integration ocaml-sha blocks dune upgrade by depending on jbuilder.transition. There is already pull request implementing this:

#42

The Travis configuration has:

install: wget https://raw.githubusercontent.com/ocaml/ocaml-travisci-skeleton/master/.travis-docker.sh
matrix:
 - DISTRO=alpine OCAML_VERSION=4.02.0

.travis-docker.sh does:

echo FROM ocaml/opam:${DISTRO}_ocaml-${OCAML_VERSION} > Dockerfile

However:

$ docker pull ocaml/opam:alpine_ocaml-4.02.0
Error response from daemon: manifest for ocaml/opam:alpine_ocaml-4.02.0 not found

Sha1.file_fast raises Failure and Sha1.file raises Sys_error on ENOENT. This report is made with the hope that a future maintainer might correct this issue.

The license is currently GPL2 without any exceptions, and this is causing problems. I'll like all the ocaml-sha source code to be relicensed under BSD (all the .c .h are effectively already under this license in the haskell packages where you can find them)

Also there's one line contributed by @samoht, please add your agreement/disagreement here

adding @avsm