Giter Club home page Giter Club logo

azure-active-directory's Introduction

azure-active-directory

An implementation of the Azure Active Directory OAuth 2.0 flow.

azure-active-directory's People

Contributors

djluck avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

azure-active-directory's Issues

Respect for requestPermissions?

Is there a way to respect scope/permissions requests passed by the application via options.requestPermissions?

For instance, in this google login example, the "scope" URL argument is passed to the dialog, asking for additional permissions from the end user: https://github.com/meteor/meteor/blob/devel/packages/google/google_client.js#L29

Is this possible in azureAd? Does combining request scopes into a URL element -- as in the google example -- work for azure oauth login?

HTTP calls incorrectly expected to return JSON

https://github.com/djluck/azure-active-directory/blame/master/lib/serverHttp.js#L18

The response that you get from HTTP data contains the following attributes:

statusCode Number
    Numeric HTTP result status code, or null on error.
content String
    The body of the HTTP response as a string.
data Object or null
    If the response headers indicate JSON content, this contains the body of the document parsed as a
    JSON object.
headers Object
    A dictionary of HTTP headers from the response. 

When adding a resource for the Onenote API and try to get page content, the content is not returned as JSON, but as a string of HTML. This means that response.data is null and the request throws an exception. ๐ŸŽ‰ TypeError: Cannot read property 'error' of null

https://docs.meteor.com/api/http.html

Unhelpful Accounts.onCreateUsers call

Hi @djluck, thank you for creating this cool package ๐Ÿ‘
I just have one minor concern...Should we put onCreateUsers [https://github.com/djluck/azure-active-directory/blob/master/azure_ad_server.js#L5] to package? IMO, onCreateUsers can be called only once so it will be a limitation if we want not only azure sso but also facebook, twitter...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.