djirdehh / crypto_vue Goto Github PK

So the service worker file generated is a nice chunky 5MB

1. If there's room for improvement, will love to explore how we can cut our bundle sizes down to the users
2. All the images stored in the static folder, are all needed or can we remove some that are unused?

💃 🕺

Some ways to improve app's actual performance

1. Certain images are still of 75kb. It appears they haven't been minified.
2. Use CSS spritesheet to display logo of cryptocurrencies on first page.
3. Using async and defer attributes on script tags which are not needed at loading time.

Hey,

It's just a detail, but there's no Logo for Cardano & Bitcoin Gold.

I guess they were not in the top 10 when you built the website.

Nice work tho !

👋🏻 Hey @djirdehh ,

I'm opening this issue just to let you know that Crypto_Vue inspired one of my last project. On my spare time I've made cryptoReact. The idea and UI is the same as Crypto_vue, the framework and some of the logic is different. You can find it here:

Repo: https://github.com/xunga/CryptoReact-
Demo: https://xunga.github.io/CryptoReact-/

I've mentioned and linked this project in my repo and in the app.
Thanks for your inspiration.

Cheers from Berlin!

BCC is Bitcoin Connect
BCH is Bitcoin Cash

add a price history graph in the detail page

and perhaps a sparkline in the overview page

Hello,

Thanks for this awesome project, I love it :) I would like to know how chan I change the currency value to EURO ?

Thanks :)

Add Global Market Cap across all crypto currencies

Maybe we can also add percentage of total crypto cap for each currency or maybe a doughnut chart?

Looking for more design input.

The back arrow looks like arrow to switch between currencies. I was confused at first.

Could you clarify which license, if any, the code and assets are released under? Preferably by adding one to the repo?

I ask because I'd like to use the your logo set in a similar project I'm playing around with but only with permission of course.

In any case, awesome app!

Wrong link to CoinMarketCap in "What's this?"

Hi Hassan @djirdehh Browsing through vuejs repo came across weex library for vue-native. So is there a possibility for crypto_vue-native? vuejs/vue#2119

"Weex: A framework for building Native Mobile cross-platform UI"
http://alibaba.github.io/weex/ based on vuejs.
https://weex.incubator.apache.org/

Awesome app!

But when you click on a single crypto, looks like the route is just "/selected". So if I refresh on that page, the app doesn't know which crypto I clicked on previously. I imagine it would be a relatively simple fix. Great job though, it looks really nice.

As the Vue app takes time to load for the first time and in that case service workers also don't help, there is a real need to alteast display something to the user. This will increase the perceived performance of the app.
My idea is to show the blue theme background and a simple preloader (or just some text to further increase the speed) and hiding the loader as soon as the Vue app can take over.