diviproject / atomic-swaps Goto Github PK

Currently, the project relies on divid and diviutil to parse public and private keys. What I would like to see in the next release is a way to parse keys without having to have the entire chain parameters saved.

If you look at address.go in diviutil: https://github.com/DiviProject/diviutil/blob/master/address.go

There is a way to decode addresses.
This decoding is dependent on params.go in divid/chaincfg.

I would like to modify it so that you can just specify the type of encoding the key is. So that you can decode the address.

This would mean that:

func DecodeAddress(addr string, defaultNet *chaincfg.Params) (Address, error) {

}

Would be simplified into something like this:

func DecodeAddress(addr string, addressConfig addrConfig) (Address, error) {

}

At https://atomic-swaps.diviproject.org/api
"[string]secretHash
The secret hash (in hex bytes) to give a participant to redeem atomic swap funds."
Should say "to give the counterparty (or intended person) to participate in an atomic swap"

The 'participate' method should say [secretHash] instead of [secret]
$ atomicswap participate [address] [amount] [secret]
$ Do you want to publish this transaction? [y/N]
$ yes

Inside the 'redeem' function description there's a typo '[secret]hash' as opposed to '[string] secretHash'
[secret]hash
The secret hash that was created during an initiate or participate atomic swap HTTP call.

Other minor typos as well that will get caught in the next pass.

There's seems to be no ability to set an expiry date by which the refund should be triggered at the earliest. You should not be able to trigger a refund immediately, but you should also be able to specify such a minimum-time-till-refundable. Nobody will participate in an atomic swap if the counterparty can immediately exit their commitment.

Also, if you're locally running one full node of each, it seems hard to specify the direction of the trade. Perhaps some syntax like 'DIV > BTC' vs 'BTC > DIV' would help make it clear which transaction-direction you're participating in.