divio / aldryn-categories Goto Github PK

When CategoryManyToManyField() is used, no M2M table is created when manage.py makemigrations is issued.

Versions used:
aldryn-categories==0.1.1
Django==1.7.4

Will provide more specific info, when needed.

If I try to add an instance of a model which uses CategoryManyToManyField throught the admin, and a category is not translated in the current interface language, I get the following error
https://gist.github.com/yakky/13d89d1c71938dd95d9b

running python manage.py makemigrations aldryn_categories creates a new migration, so there seems to be changes not addressed in the current migrations. I suspect it's actually changes in the latest django-parler base-class that causes this.

This can cause problems when creating migrations for other apps that have relations to aldryn-categories, since Django 1.7 will sneakily create the missing migration for aldryn-categories, even if it is installed somewhere in site-packages.

Thanks.

Taken from django-cms/django-cms#6430

Summary

Expected behaviour

A category named "blockchain" should be created.

Actual behaviour

Got TypeError

Environment

The following is the output of pip freeze

pip-freeze.txt

Hi,
With the current version we cannot delete any of the aldryn categories, through the admin panel.

In the comment of models.py, it says:

I would have preferred to make this a base class "CategoryBase" which
is Abstract, then subclass it as a concrete Category class. But, Parler
cannot be applied to an Abstract class.

I don't think it's true that parler cannot be applied to abstract model. You can define translation models manually like http://django-parler.readthedocs.org/en/stable/api/parler.fields.html

I got this weird delete() takes exactly 1 argument (2 given) error when deleting a category

See https://gist.github.com/yakky/041b263da0747ab62aba

Please consider using either python-slugify (https://github.com/un33k/python-slugify) or awesome-slugify (https://github.com/dimka665/awesome-slugify) instead of django's own slugify function which is not unicode friendly. Alternatively, leave a place to configure what slugify function to use.

I'm not sure if it's a treebeard or aldryn-categories bug. I have two languages on my site, Chinese and English. If I log into admin site in English and create a category in Chinese tab, the content would be saved to English. The opposite is also true. If I log into admin site in Chinese and create a category in English tab, the content is saved to Chinese. It appears to me that the language tab doesn't matter at all. It all depends on what language of the Admin site is in at the moment.

I'm pretty sure it's not parler's problem per se because I have other model in parler that doesn't suffer from this problem.

We should have to do this:

category = CategoryForeignKey(Category, <options>)

It should just be:

category = CategoryForeignKey(<options>)

Fixed in PR #37 if you mind to merge it one day…

I have extended Page to include Categories using the following model:

# File: models.py
from django.db import models
from cms.extensions import PageExtension
from cms.extensions.extension_pool import extension_pool
from aldryn_categories.fields import CategoryManyToManyField

class CategoryExtension(PageExtension):
    categories = CategoryManyToManyField()

extension_pool.register(CategoryExtension)

Also added Categories to the tool bar:

#File: cms_toolbars.py
from cms.toolbar_pool import toolbar_pool
from cms.extensions.toolbar import ExtensionToolbar
from django.utils.translation import ugettext_lazy as _
from .models import CategoryExtension


@toolbar_pool.register
class CategoryExtensionToolbar(ExtensionToolbar):
    # defines the model for the current toolbar
    model = CategoryExtension

    def populate(self):
        # setup the extension toolbar with permissions and sanity checks
        current_page_menu = self._setup_extension_toolbar()

        # if it's all ok
        if current_page_menu:
            # retrieves the instance of the current extension (if any) and the toolbar item URL
            page_extension, url = self.get_page_extension_admin()
            if url:
                # adds a toolbar item in position 0 (at the top of the menu)
                current_page_menu.add_modal_item(_('Categories'), url=url,
                    disabled=not self.toolbar.edit_mode, position=0)

Now I can add and select categories to each page, but I have realized that the categories are always in English even if I am on a different language: http://127.0.0.1:8000/de/

Also:

• If I try to add a new German category through my new tool menu, it is added to the English categories instead.
• If I try to modify or delete an existing category from the tool menu I got redirected to a not existing page: http://127.0.0.1:8000/en/admin/my-app/categoryextension/2/change/?cms_path=%2Fen%2F

Steps to reproduce the error:

• Install the versions django-cms=3.4.3, Django==1.10.7, aldryn-categories==1.0.4.
• Add the Category extension using the files models.py and cms_toolbars.py displayed previously.
• Click on Page -> Categories
• Click on the Delete button

Any idea what could be wrong?

Would be great having a small tutorial of how to implement the categories into pages, because I think that will be the most common use case.