divineomega / do-file-cache Goto Github PK

Hi,
I am on Windows and therefore the sys_getloadavg() function does not exist and even though I haven't touched the default configuration "'unixLoadUpperThreshold' => -1," as the suggestion in the exception message reads, the exception is nevertheless thrown. I think this check

should be done instead before this line

Best regards,
Dimitar

In the line, error suppression (@) is used:
https://github.com/DivineOmega/DO-File-Cache/blob/master/src/DOFileCache.php#L136

Unfortunately, upon heave use of this code, your error log will get cluttered with error messages. Surely the @ prevents errors to be written to standard output (/web browser), but errors are still written to custom error handlers and log files.

Hence, I propose to not use error suppression, and solve the real problem at hand here. Data is only serialized whenever it is not a string:
https://github.com/DivineOmega/DO-File-Cache/blob/master/src/DOFileCache.php#L52 , so to clarify: ints, bools and floats are serialized as well. My suggestion is to always serialize, strings too, and also always unserialize. This way the get procedure will not result in loads of notices in the log any more.

The only downside is that strings will have to be serialized, increasing some storage space and computation time. This does not outweight the benefit of having well-defined storage characteristics, imho.

Btw, I'm posting this as a user of the divineomega/password_exposed library, which is an example of this issue in practice.

According to clearstatcache function reference, the file state cache is effected on following related file functions:

Affected functions include stat(), lstat(), file_exists(), is_writable(), is_readable(), is_executable(), is_file(), is_dir(), is_link(), filectime(), fileatime(), filemtime(), fileinode(), filegroup(), fileowner(), filesize(), filetype(), and fileperms().

To avoid file stat caching, it should use this function before manipulating any file operation :).