dinchak / node-serialosc Goto Github PK

It would be nice to be able to stop/restart the global connections in a running node process. This would be helpful in development scenario where code is reloaded in a live process and probably for tests too.

This requires the ability to have sequences of start, stop being idempotent.

An option to support that would be to introduce a stop method that would close underlying socket for receiver and serialoscEmitter and make sure sockets are created in start. Currently sockets are created in OscReceiver and OscEmitter constructors and never released.

What do you think?

hi - just wanted to suss enthusiasm levels regarding the prospect of getting an OSC workflow running in deno

It seems like the state array is initialized after the map by integer loop runs causing

/Users/dexter/workspace/personal/monome-react/server/node_modules/serialosc/lib/grid.
js:132
      state[y].value = arr[y];
                     ^

TypeError: Cannot set property 'value' of undefined
    at Grid.map (/Users/dexter/workspace/personal/monome-react/server/node_modules/se
rialosc/lib/grid.js:132:22)

Have added a quick PR to fix. Thanks for the library! It's been super useful so far.

#2