dijji / customwindowsproperties Goto Github PK

Say I have 2 installed custom properties, prop1 and prop2. If I select prop1 in the top left box, and prop2 in the bottom left box, the uninstall button uninstalls prop2. Perhaps this is not the most intuitive way to do it. A couple of times, I would select the property in the top left box and click on uninstall only to find that I uninstalled some selected property in the bottom left box.

The new panels look good.

Some suggestions:

1- In the Installed panel, you changed the order of the groups? I suggest reverting to the older sorting (same as FileMeta, i.e. native groups at the top, then non native properties (3rd party) at the bottom

2- In the Saved panel, add some indication to which property is installed (bold face? different color? star?). Also, perhaps add an uninstall option in the context menu. It would be nice to have full install/uninstall control on my custom properties in the Saved panel, since that's where I actually try to control them. I never find myself looking at my properties in the Installed panel.

3- In the Saved panel, if I select property1 and right click on it, then right click on property2, the context menu is still for property1. The selection doesn't move to property2.

4- Clicking on a non-installed saved property in the Saved panel, the save button is available. Clicking on an installed saved property, the save button is grayed out. The only reason for that that I could see is if the save button EDITS a saved non-installed property, correct? However, it only does that if the property name is kept the same and other fields are edited. If the name is edited, it saves it to a new property, which i think it shouldn't, or at least there should be options like "save and replace" and "save to new property". In short, I think that for any non-installed saved property, the user should be able to edit all its info (including name) and also have the option to start with a saved property, make modifications and save to a new property (if the name is changed; if the name is kept the same, the user gets a prompt asking if they want to replace the old property, or keep both by renaming the new one to <oldname_i>).

In the top right box, the checkbox options can be toggled with a click anywhere on that line, even if the click is on the far right. Sometimes, i click in the white space to move the focus from some field, but end up checking or unchecking another option.

Edit:
This was due to not using the (correct?) format of Category.Property for the name.

Having property names in the install and uninstall buttons certainly lessens the confusion, but at times I'm still not sure what the Delete button will delete (although I know it can only delete non-installed properties from the top left box, but I have to consciously remind myself of that).
Not sure grouping buttons that act on different boxes is the optimal way to go, but if you decide to keep it that way, note the following glitch:

Create 2 properties: Custom.Prop1 and Custom.Prop2, and save them.
Click on one of the 2 properties in the top left box -> the install button says "install Custom.Prop1/2".
Click on Custom in the top left box -> the install button says "install Custom.".
Expected behavior: either grayed out install button, or let it say "install Custom"

Also, FYI, in LocalizedHelp.resx, line 121, you have an extra white space just before "regardless".

1. For fields that have a checkbox, to show the help text, you have to check the box. Is there an easier way to show the help text without modifying the field? Clicking on the name of the field? Or changing the checkbox to a true/false drop list, and showing the help text when the user open the list? This is just a personal preference. I wouldn't like to change the value of a field just to show its help text.

2. Installed panel: clicking on whitespace to clear selection? Decided not to do that?

3. ColumnIndexType: help text needs attention at the end.

4. isGroup: help text reads "A property description with IsGroup="true" should specify a , otherwise it isn't a useful property". Specify a what? It is like that in the Microsoft docs. I couldn't tell what they meant to say.

5. isTreeProperty: no explanation in MS docs. Current help text says: Whether this is a tree property. Not sure what this means... If you understand what this field is, could you add a clear description?

6. SearchRawValue: same as above.

7. The editor panel looks crammed vertically. The drop list of EditControl barely fits. I suggest adding some space below the last field, and the user can just scroll down in the editor panel.

8. EditControl: typo in the last line of help. "late" should be "later."

9. Weird issues when saving and deleting. I'll try my best to explain what happened. This was the first property i'm editing. No saved properties yet. I clicked on save. The prop got saved, but a message box appeared asking if i want to discard changes. I chose no. Then i went to the saved panel. Right clicking on the property resulted in the same message. I had to discard changes (there weren't any changes though) to be able to delete it. I tried reproducing this behavior but i couldn't. But then this happened again when i created a new set of properties. Will try to better understand when this is happening. But what i am sure of is that when this message appears, there definitely aren't any changes to be discarded.

10. I created the following property: Custom.Documents.Journal. Context menu of Journal has the 3 options available. For Documents, only export is available. What if I want to delete (or even install) all properties under Documents? For Custom, nothing is available (again, i might want to install or delete everything in that category). Does it even make sense to export anything that's not in the lowest level of the tree? The exported propdesc of Custom.Documents has information for Custom.Documents.Journal. I don't think Custom.Documents should have a propdesc in the first place.

11. When i select Documents, i expected the editor to show a blank new property with the name Custom.Documents, which can not be saved obviously, where i would add something to the name (e.g., .Year). Is that unreasonable or not an expected behavior? Anyway, after i create Year and save it (now i have in the saved list Custom.Documents.Journal and Custom.Documents.Year), if i click on Year then on Documents, the editor displays the details of Year. If i click on Journal then Documents, the editor displays the details of Journal. I think there's something to be addressed there.

12. Having created Custom.Documents.Journal and installed it (now the install button is disabled), i create Custom.Videos and save it. The install button is enabled. I then click on Custom.Documents and the install button is still enabled. I then click on Custom.Documents.Journal, the install button gets disabled, and stays disabled when i select Custom.Documents. So in essence, moving from a non-installed property to an installed property disables the install button (correct), but moving from a non-installed property to the group header of an installed property does not disable the install button (incorrect, given the way things are right now, which is the installed button always disabled for group headers; i argue that if there are properties yet to be installed, the user should be able to install them all through their group header).

13. Still no indication of which saved properties are installed in the saved panel. Is that something you decided not to do?

This is where I stopped testing. I have deadlines but I'll keep testing whenever I can and report back. Hopefully, everything will be thoroughly tested by end of next week.

Top right window: if "name" is invalid (A.b, for example), "Installed" displays invalid name only when focus goes to a box other than name.
It would be more helpful if it keeps displaying invalid name even when the name is being edited as long as it is still invalid.
Justification: I started with an invalid name, then went to other options below and didn't look back to "Installed". When i tried saving, the "save" button was grayed out and it took me a while to see the "invalid name" at the top.
Also, possibly make buttons enabled/disabled dynamically. Currently, if name is invalid but focus is still on "Name", the "save" button is enabled and clickable.

Currently, under Basics, the property name should have the format Category.Property.
It could be more intuitive to separate them into 2 fields, Category name and Property name.

Once an existing property in the bottom left box is selected, it can not be deselected.

If a property is selected in the bottom left box, and a new property is being edited in the top right box, the information displayed in the bottom right box can be confusing.
If the focus is in one the fields in the top right box, a help message for that field is displayed in the bottom box. If the focus is not in any field, the bottom box reverts to displaying the info of the selected property from the bottom left box.